Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky test-timers-unref-active-unenrolled-disposed #5351

Closed
Trott opened this issue Feb 21, 2016 · 0 comments
Closed

investigate flaky test-timers-unref-active-unenrolled-disposed #5351

Trott opened this issue Feb 21, 2016 · 0 comments
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Comments

@Trott
Copy link
Member

Trott commented Feb 21, 2016

Example failure:

/cc @Fishrock123
@Trott Trott added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. labels Feb 21, 2016
@Fishrock123 Fishrock123 mentioned this issue Feb 21, 2016
Closed
rvagg pushed a commit that referenced this issue Feb 27, 2016
@Fishrock123 @rvagg
test: increase timeouts on some unref timers tests
0f54553 
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
@Fishrock123
test: increase timeouts on some unref timers tests
213e13e 
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@Fishrock123
test: increase timeouts on some unref timers tests
99269ff 
Fix: #5351
Refs: #4561
PR-URL: #5352

Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Trott