New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable test-ubsan.yml #52753

Open

RafaelGSS opened this issue Apr 29, 2024 · 1 comment

Labels

help wanted meta

Member

RafaelGSS commented Apr 29, 2024

During the latest Node.js major release (#52505) we have had to disable test-ubsan.yml due to failing tests on a recent V8 update (#52560).

I have tried to make it work, but due to the short time frame I had to fix it, we have decided to simply disable it for now.

Some insights:

It seems clang provides a better output and some docs we could use in the suppressions file.
- Changing from g++ to clang for UBSAN will require changing all the suppression file

The text was updated successfully, but these errors were encountered:

RafaelGSS added the help wanted label

RedYetiDev added the meta label

Member

richardlau commented May 10, 2024

For reference, the ubsan failure in #52293 (comment) is abseil/abseil-cpp#1634

RafaelGSS mentioned this issue

workflow: re-enable ubsan #53142

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment