clang build error for v22.0.0 #52675
Description
Version
v22.0.0
Platform
Linux d738e45a1dcc 6.6.22-linuxkit #1 SMP Fri Mar 29 12:21:27 UTC 2024 aarch64 GNU/Linux
Subsystem
v8
What steps will reproduce the bug?
Attempting to build with clang (tried 15 and 18) both result in:
$ clang++ -o /home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/wasm/wasm-external-refs.o ../deps/v8/src/wasm/wasm-external-refs.cc '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DICU_NO_USER_DATA_OVERRIDE' '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64' '-D__STDC_FORMAT_MACROS' '-DV8_TARGET_ARCH_ARM64' '-DV8_HAVE_TARGET_OS' '-DV8_TARGET_OS_LINUX' '-DV8_EMBEDDER_STRING="-node.10"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT=1' '-DV8_ENABLE_PRIVATE_MAPPING_FORK_OPTIMIZATION' '-DOBJECT_PRINT' '-DV8_INTL_SUPPORT' '-DV8_ATOMIC_OBJECT_FIELD_WRITES' '-DV8_ENABLE_LAZY_SOURCE_POSITIONS' '-DV8_USE_SIPHASH' '-DV8_SHARED_RO_HEAP' '-DNDEBUG' '-DV8_WIN64_UNWINDING_INFO' '-DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH' '-DV8_USE_ZLIB' '-DV8_ENABLE_SPARKPLUG' '-DV8_ENABLE_MAGLEV' '-DV8_ENABLE_TURBOFAN' '-DV8_ENABLE_WEBASSEMBLY' '-DV8_ENABLE_JAVASCRIPT_PROMISE_HOOKS' '-DV8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA' '-DV8_ALLOCATION_FOLDING' '-DV8_ALLOCATION_SITE_TRACKING' '-DV8_ADVANCED_BIGINT_ALGORITHMS' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/opt/zlib.net/v1.3.1/include -I/opt/openssl.org/v1.1.1w/include -I../deps/v8 -I../deps/v8/include -I/home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj/gen/inspector-generated-output-root -I../deps/v8/third_party/inspector_protocol -I/home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj/gen -I/home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj/gen/generate-bytecode-output-root -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/v8/third_party/zlib -I../deps/v8/third_party/zlib/google -I../deps/v8/third_party/abseil-cpp -I../deps/v8/third_party/fp16/src/include -pthread -Wno-unused-parameter -Wno-return-type -flax-vector-conversions -Wno-invalid-offsetof -fno-strict-aliasing -O3 -fno-omit-frame-pointer -fdata-sections -ffunction-sections -O3 -fno-rtti -fno-exceptions -std=gnu++17 -MMD -MF /home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/.deps//home/builder/actions-runner/_work/pantry/pantry/builds/nodejs.org-22.0.0/out/Release/obj.target/v8_base_without_compiler/deps/v8/src/wasm/wasm-external-refs.o.d.raw -c
../deps/v8/src/wasm/wasm-disassembler.cc:525:17: error: no member named 'setprecision' in namespace 'std'
525 | o << std::setprecision(std::numeric_limits<float>::max_digits10) << f;
| ~~~~~^this is fixed upstream in v8/v8@500de8b (specifcially: #include <iomanip>)
How often does it reproduce? Is there a required condition?
every time.
What is the expected behavior? Why is that the expected behavior?
successful compilation. injecting the header fixes it: see pkgxdev/pantry@943cfc3
What do you see instead?
the above compilation error
Additional information
updating the dep from upstream should resolve it.