Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream.finished docs are lacking #52544

Closed
KhafraDev opened this issue Apr 15, 2024 · 0 comments · Fixed by #52551
Closed

stream.finished docs are lacking #52544

KhafraDev opened this issue Apr 15, 2024 · 0 comments · Fixed by #52551
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors.

Comments

@KhafraDev
Copy link
Member

What is the problem this feature will solve?

The stream.finished docs do not mention that this works for web streams, nor does it mention which version of node added support for web streams.

What is the feature you are proposing to solve the problem?

Mention that stream.finished works for web streams and add in a history section that mentions that it's only available in node v18.14.0 (?) and above. #46205

What alternatives have you considered?

N/A
@KhafraDev KhafraDev added doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. labels Apr 15, 2024
@debadree25 debadree25 added the good first issue Issues that are suitable for first-time contributors. label Apr 15, 2024
@climba03003 climba03003 mentioned this issue Apr 16, 2024
Merged
@RedYetiDev RedYetiDev moved this from Awaiting Triage to Done in Node.js feature requests Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. feature request Issues that request new features to be added to Node.js. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: correct stream.finished changes climba03003/node
2 participants
@debadree25 @KhafraDev