You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I guess the --require argument gets forwarded to the internal Worker (along with env and other command line args) and in contrast to --import this seems to have an effect.
Not sure if the problem is the different behavior of --require vs --import in Worker.
But in general I think we should not blindly forward and command line args to the internal hooks worker.
Edit: Thinking once more I think we should forward env/--require/... configs to the internal worker. People migth want to get e.g. Otel into this thread to capture traces.
The text was updated successfully, but these errors were encountered:
Flarna
added
loaders
Issues and PRs related to ES module loaders
module
Issues and PRs related to the module subsystem.
labels
Apr 5, 2024
The current recommendation to install customization hooks is to use
--import
.But
--import
is still marked as experimental therefore not the preferred thing to use in production.If I use the stable alternative
--register
the loader hooks are installed twice.Easy to reproduce:
run with
--require
results inrun with
--import
:I guess the
--require
argument gets forwarded to the internalWorker
(along with env and other command line args) and in contrast to--import
this seems to have an effect.Not sure if the problem is the different behavior of
--require
vs--import
in Worker.But in general I think we should not blindly forward and command line args to the internal hooks worker.
Edit: Thinking once more I think we should forward env/--require/... configs to the internal worker. People migth want to get e.g. Otel into this thread to capture traces.
The text was updated successfully, but these errors were encountered: