macOS: `fs.watch` does not report delete of watched folder

[bpasero]

Version

v18.19.1

Platform

Darwin MBP-13-Work.local 23.4.0 Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:06 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T8103 arm64

Subsystem

fs

What steps will reproduce the bug?

Install a fs.watch on a folder path:

require("fs").watch("path to a folder", console.log);

Delete the folder from disk, for example with a fs.rm call.

How often does it reproduce? Is there a required condition?

Everytime.

What is the expected behavior? Why is that the expected behavior?

Deleting the watched folder path reports an event, similar to how an event is reported when watching a file path.

What do you see instead?

No event is fired when deleting the watched folder path.

Additional information

On Windows and Linux and event is reported.

[akhoshrozeh]

Platform

Darwin MBP 23.3.0 Darwin Kernel Version 23.3.0: Wed Dec 20 21:28:58 PST 2023; root:xnu-10002.81.5~7/RELEASE_X86_64 x86_64

Node version

v18.19.1

I see fs.watch() emits a "rename" event when I delete a file. I'm guessing this is because of how of the OS is really unlinking a file under the hood. Does it not emit that type of event either?

[bpasero]

@akhoshrozeh a rename event is emitted if you delete a file, but this is about watching a folder path and then deleting that folder path. The folder can be empty, does not make a difference it seems.

[santigimeno]

Potential fix: libuv/libuv#4376