-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aarch64 and arm64 inconsistencies #5175
Comments
I don't mind unifying it a little like we do for x86/ia32 (although even there we're not fully unified thanks mainly to gyp). @jbergstroem as an aside: both |
@rvagg I would personally prefer using them only if set so we can fall back on defaults but don't have a strong opinion about it. Don't break what works (like I did last time), I guess. |
`Makefile` is now consistent with `configure` regarding how we treat aarch64. PR-URL: nodejs#5191 Fixes: nodejs#5175 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
./configure
currently sets host/target_arch asarm64
whereasMakefile
will treat it asaarch64
(uname -s
doesn't match anything). Suggesting we give Makefile a similar treatment?/cc @nodejs/build
The text was updated successfully, but these errors were encountered: