Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run subtests flagged as only also when parent is not flagged #51261

Closed
simone-sanfratello opened this issue Dec 22, 2023 · 4 comments
Closed
Labels
feature request Issues that request new features to be added to Node.js. stale test_runner Issues and PRs related to the test runner subsystem.

Comments

@simone-sanfratello
Copy link

simone-sanfratello commented Dec 22, 2023

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

actually not a bug, but a DX improvement

How often does it reproduce? Is there a required condition?

I'd like the test named want to run only this to run, but to do so also the parent must have the {onyl:true} option

test('want to run the subtests here', async (t) => {
  t.test('want to run only this', { only: true });
  t.test('dont run that');
});

test('this test is not run');

What is the expected behavior? Why is that the expected behavior?

The parents tests should run as well, as they were flagged

What do you see instead?

no tests run

Additional information

No response

@marco-ippolito marco-ippolito added the feature request Issues that request new features to be added to Node.js. label Dec 22, 2023
@simone-sanfratello
Copy link
Author

Happy to work on this

@bakkot
Copy link

bakkot commented Dec 23, 2023

See #48932

Copy link
Contributor

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Mark issue so that it is never considered stale label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Jun 21, 2024
@MoLow
Copy link
Member

MoLow commented Jun 22, 2024

Fixed by #52296

@MoLow MoLow closed this as completed Jun 22, 2024
@MoLow MoLow added the test_runner Issues and PRs related to the test runner subsystem. label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. stale test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

No branches or pull requests

4 participants