Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @atlowChemi for collaborator #48603

Closed
benjamingr opened this issue Jun 29, 2023 · 7 comments · Fixed by #48757
Closed

Nominating @atlowChemi for collaborator #48603

benjamingr opened this issue Jun 29, 2023 · 7 comments · Fixed by #48757
Labels
meta Issues and PRs related to the general management of the project.

Comments

@benjamingr
Copy link
Member

Chemi has been helping a bunch in areas we don't have many contributors at the moment and involve pretty complicated spec related work in PRs like #47821 and bcd35c3 - they have been very open to feedback and the project could benefit from their help. We could use them as a reviewer in related PRs and it'd be nice if they could resume-ci without messaging me on openjs-slack.

Pull Requests in Node.js: https://github.com/nodejs/node/issues?q=author%3AatlowChemi+sort%3Aupdated-desc+
Commits in Node.js: https://github.com/nodejs/node/commits?author=atlowChemi
Comments in Node.js: https://github.com/nodejs/node/issues?q=commenter%3AatlowChemi+sort%3Aupdated-desc+

@nodejs/collaborators @atlowChemi

@atlowChemi
Copy link
Member

Thank you for the nomination @benjamingr! This is really exciting, and a true honor 🙏🏽
And TBH, I think I have been nagging @MoLow for re-runs a lot more than you 😂

@cjihrig
Copy link
Contributor

cjihrig commented Jun 29, 2023

Big +1

@ErickWendel
Copy link
Member

+1 too!!

@VoltrexKeyva VoltrexKeyva added the meta Issues and PRs related to the general management of the project. label Jun 29, 2023
@benjamingr
Copy link
Member Author

Looks like this nomination has passed 🎉 @nodejs/tsc

@MoLow
Copy link
Member

MoLow commented Jul 9, 2023

Scheduled an onboarding for Thursday 14 CEST @nodejs/tsc members welcome to join

@danasartov
Copy link

Congratulation Chemi!
Well deserved

@ErickWendel
Copy link
Member

so happy for you @atlowChemi keep rocking!!

juanarbol pushed a commit that referenced this issue Jul 13, 2023
PR-URL: #48757
Fixes: #48603
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
PR-URL: nodejs#48757
Fixes: nodejs#48603
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Aug 14, 2023
PR-URL: nodejs#48757
Fixes: nodejs#48603
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this issue Sep 12, 2023
PR-URL: #48757
Fixes: #48603
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this issue Sep 13, 2023
PR-URL: #48757
Fixes: #48603
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this issue Sep 17, 2023
PR-URL: #48757
Fixes: #48603
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants