-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node:test] Test shorthands return undefined
#48557
Labels
test_runner
Issues and PRs related to the test runner subsystem.
Comments
7 tasks
shockerqt
added a commit
to shockerqt/node
that referenced
this issue
Jun 27, 2023
`test.todo`, `test.only` and `test.skip` are expected to return the same as `test`. This commit corrects the inconsistent behavior of these shorthands. Fixes: nodejs#48557
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
`test.todo`, `test.only` and `test.skip` are expected to return the same as `test`. This commit corrects the inconsistent behavior of these shorthands. Fixes: nodejs#48557 PR-URL: nodejs#48555 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Aug 14, 2023
`test.todo`, `test.only` and `test.skip` are expected to return the same as `test`. This commit corrects the inconsistent behavior of these shorthands. Fixes: nodejs#48557 PR-URL: nodejs#48555 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v20.3.1
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
By the docs:
and
So I expect that shorthands will have the same return type as
test/describe/it
functions.What do you see instead?
Test shorthands return
undefined
Additional information
The issue was discovered at DefinitelyTyped/DefinitelyTyped#65871
The text was updated successfully, but these errors were encountered: