-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test-child-process-pipe-dataflow failing on Windows #48300
Comments
/cc @nodejs/platform-windows @nodejs/build |
I am investigating on https://ci.nodejs.org/computer/test-azure_msft-win11_vs2022-arm64-3/ |
Looking at the Node.js 16 daily builds, the first failure there appears to be https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-v16.x-staging/36/, i.e. https://ci.nodejs.org/job/node-test-binary-windows-js-suites/21215/. Those failures happened on:
According to #48331, the test is failing due to a difference in behaviour of Looking at the prior windows-update-reboot run before those jobs we can see that git was updated 09:00:37
09:00:37 You have git v2.40.1 installed. Version 2.41.0 is available based on your source(s).
09:00:53
Progress: Downloading git.install 2.41.0... %
...
Progress: Downloading git.install 2.41.0... 100%
09:00:56
09:00:56 git.install v2.41.0 [Approved]
09:00:56 git.install package files upgrade completed. Performing other installation steps.
09:00:57 Using Git LFS
09:00:57 Installing 64-bit git.install...
09:01:28 git.install has been installed.
09:01:28 git.install installed to 'C:\Program Files\Git'
09:01:28 git.install can be automatically uninstalled.
09:01:29 The upgrade of git.install was successful.
09:01:29 Software installed to 'C:\Program Files\Git\'
09:01:33
Progress: Downloading git 2.41.0... 62%
Progress: Downloading git 2.41.0... 100%
09:01:33
09:01:33 git v2.41.0 [Approved]
09:01:33 git package files upgrade completed. Performing other installation steps.
09:01:33 The upgrade of git was successful.
09:01:33 Software installed to 'C:\ProgramData\chocolatey\lib\git'
09:01:34 git.install v2.41.0 is the latest version available based on your source(s). (Similarly https://ci.nodejs.org/job/windows-update-reboot/label=test-rackspace-win2012r2_vs2017-x64-4/2370/consoleFull for the other machine.) |
It's might be due to latest Git 64-bit version switch to |
I can confirm that the issue is caused by Git for Windows v2.41.0. With v2.40.0 the test passes locally. |
Probably related to git-for-windows/git#4464 |
I've also seen |
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: #48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Refs: nodejs#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: #48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> PR-URL: #48537
Refs: #48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: #48537 Backport-PR-URL: #48650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
The upstream issue was closed without a fix. |
Refs: nodejs#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Refs: nodejs#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
It's almost constantly failing now, perhaps we should just skip it on Windows until it's properly fixed to at least give the CI some green space.. |
This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that. PR-URL: #49563 Refs: #48300 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that. PR-URL: #49563 Refs: #48300 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that. PR-URL: nodejs#49563 Refs: nodejs#48300 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Refs: nodejs/node#48300 (comment) Refs: nodejs/reliability#597 (comment) PR-URL: nodejs/node#48537 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
It's also failing on
v16.x-staging
, so I don't think it's related to a recent change onmain
, maybe a change with the infra?The text was updated successfully, but these errors were encountered: