Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make disk- blob transferable #47666

Closed
jimmywarting opened this issue Apr 22, 2023 · 7 comments
Closed

Make disk- blob transferable #47666

jimmywarting opened this issue Apr 22, 2023 · 7 comments
Labels
feature request Issues that request new features to be added to Node.js. stale

Comments

@jimmywarting
Copy link

jimmywarting commented Apr 22, 2023

What is the problem this feature will solve?

I notice that Blob's transfered over workers aren't readable at all.

  • it only applies to blobs coming from fs.openAsBlob
  • in-memory constructed blobs works fine.

Right now they throw an error when trying to send them over.

mini repro:

import { Worker } from 'worker_threads'
const worker = new Worker('./worker.js')
worker.once('message', blob => {
  // Should be fine to do this as well
  blob.text()
})
// worker.js
import { parentPort } from 'node:worker_threads'
import { openAsBlob } from 'node:fs'

const blob = await openAsBlob(new URL(import.meta.url))
parentPort.postMessage(blob)

If a blob originates from a worker thread and is being sent to the main thread over postMessage, then it should still work OK to read the blob even if the worker is terminated.

originally posted by @jimmywarting in #45258 (comment)

What is the feature you are proposing to solve the problem?

Spec issue

What alternatives have you considered?

No response

@jimmywarting jimmywarting added the feature request Issues that request new features to be added to Node.js. label Apr 22, 2023
@aduh95

This comment was marked as off-topic.

@jimmywarting

This comment was marked as off-topic.

Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Jan 31, 2024
@jimmywarting
Copy link
Author

still an issue...

@github-actions github-actions bot removed the stale label Feb 1, 2024
Copy link
Contributor

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Mark issue so that it is never considered stale label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Jul 30, 2024
Copy link
Contributor

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
@jimmywarting
Copy link
Author

not fixed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. stale
Projects
None yet
Development

No branches or pull requests

2 participants