Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: preview removed when press ESC key #46876

Closed
jenthone opened this issue Feb 28, 2023 · 0 comments · Fixed by #46878
Closed

repl: preview removed when press ESC key #46876

jenthone opened this issue Feb 28, 2023 · 0 comments · Fixed by #46878
Labels
repl Issues and PRs related to the REPL subsystem.

Comments

@jenthone
Copy link
Contributor

jenthone commented Feb 28, 2023 •
edited
Loading

Version

18.12.1

Platform

Darwin 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64 x86_64

Subsystem

repl

What steps will reproduce the bug?

In repl

> 1+1 // then press ESC key

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Keep preview, only remove autocomplete

ChromeDevTools also keep the preview after pressing the ESC key
Chrome

What do you see instead?

The preview is removed

Additional information

The preview is removed by this PR: #42053
meixg added a commit to meixg/node that referenced this issue Feb 28, 2023
@meixg
repl: preserve preview on ESCAPE key press
21dc2b9 
Fix: nodejs#46876
@meixg meixg mentioned this issue Feb 28, 2023
Merged
meixg added a commit to meixg/node that referenced this issue Feb 28, 2023
@meixg
repl: preserve preview on ESCAPE key press
61416f4 
Fix: nodejs#46876
meixg added a commit to meixg/node that referenced this issue Feb 28, 2023
@meixg
repl: preserve preview on ESCAPE key press
d636ce8 
Fix: nodejs#46876
@VoltrexKeyva VoltrexKeyva added the repl Issues and PRs related to the REPL subsystem. label Mar 1, 2023
meixg added a commit to meixg/node that referenced this issue Mar 3, 2023
@meixg
repl: preserve preview on ESCAPE key press
90c08fe 
Fix: nodejs#46876
nodejs-github-bot pushed a commit that referenced this issue Mar 16, 2023
@meixg
repl: preserve preview on ESCAPE key press
2566400 
Fix: #46876
PR-URL: #46878
Fixes: #46876
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this issue Mar 18, 2023
@meixg @targos
repl: preserve preview on ESCAPE key press
d6a1232 
Fix: #46876
PR-URL: #46878
Fixes: #46876
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
danielleadams pushed a commit that referenced this issue Jul 6, 2023
@meixg @danielleadams
repl: preserve preview on ESCAPE key press
e668efa 
Fix: #46876
PR-URL: #46878
Fixes: #46876
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

repl: preserve preview on ESCAPE key press meixg/node
2 participants
@jenthone @VoltrexKeyva