Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: http response event options (agent.getName()?) #4586

Closed
jmm opened this issue Jan 8, 2016 · 2 comments
Closed

doc: http response event options (agent.getName()?) #4586

jmm opened this issue Jan 8, 2016 · 2 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. http Issues or PRs related to the http subsystem.

Comments

@jmm
Copy link
Contributor

jmm commented Jan 8, 2016

Under the http.ClientRequest response event there's an Options section that doesn't make sense. It was originally introduced with an http.getAgent() method (a2328dc) that appears to be gone. It appears to me that these options now belong to http.Agent.getName(), though with a rename: socketPath => localAddress. I'm not sure what the documentation on that param means by:

(use one of host:port or socketPath)

@mscdex mscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Jan 8, 2016
@ryansobol
Copy link
Contributor

Care to make a PR? :)

@benjamingr benjamingr added the good first issue Issues that are suitable for first-time contributors. label Mar 22, 2016
@doug-wade
Copy link
Contributor

Looking at the linked docs, it seems like this can be closed. From this comment #5993 (comment), it looks like @jasnell landed this from #5993.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants