Skip to content

Last nightly and canary binaries for Windows have no proper application icon #45025

Closed
@vsemozhetbyt

Description

@vsemozhetbyt

Version

Last nightly and canary binaries

Platform

Windows 10

What steps will reproduce the bug?

Here are the last release vs the last nightly and canary binaries:

Node1

Here is the last canary after installation:

Node2

The change have happened between v19.0.0-nightly20220717 and v19.0.0-nightly20220718:

Node3

What do you see instead?

No icons in downloaded or installed binaries.

Activity

targos

targos commented on Oct 17, 2022

@targos
Member

Diff between these versions: dabda03...0e660ce

I suspect aa3a572

added
windowsIssues and PRs related to the Windows platform.
buildIssues and PRs related to build files or the CI.
on Oct 17, 2022
richardlau

richardlau commented on Oct 17, 2022

@richardlau
Member

I suspect aa3a572

Yes, it looks like this removed the Windows resource file from the list of sources. Opened #45042 to add it back.

added a commit that references this issue on Oct 19, 2022
added a commit that references this issue on Nov 1, 2022
added a commit that references this issue on Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Participants

    @targos@richardlau@vsemozhetbyt

    Issue actions

      Last nightly and canary binaries for Windows have no proper application icon · Issue #45025 · nodejs/node