Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominating @lukekarrys as a collaborator #44828

Closed
MylesBorins opened this issue Sep 29, 2022 · 5 comments · Fixed by #45180
Closed

Nominating @lukekarrys as a collaborator #44828

MylesBorins opened this issue Sep 29, 2022 · 5 comments · Fixed by #45180
Assignees
Labels
meta Issues and PRs related to the general management of the project.

Comments

@MylesBorins
Copy link
Contributor

I would like to nominate lukekarrys as a collaborator. Luke is a member of the npm team and is focusing quite a bit on releases for npm and would like to get more involved in Node.js, especially in regards to the upcoming npm 9 release.

I am heading on parental leave for a couple months in two weeks and I think it is very important to have an npm team member how can review npm related PRs, help with any integration issues that arise, and be able to run CI. While @ruyadorno can likely support here I don't think it is fair for the npm team to rely on other folks to do this work when we have funded engineers.

While they do not currently have any contributions to Node.js directly I can vouch for their work and ethical standards. If folks are uncomfortable with making someone a collaborator until they have more explicit work directly on Node.js we could alternatively explore ways to allow Luke to run CI / CITGM without requiring a commit bit.

One thing I will advocate for, the npm team is actively working on a "sub tree" of what ships in Node.js that happens to live in another repo, npm. I believe it is extremely important for us to have more collaboration + integration between the teams. That said, totally understand if folks prefer to see more direct engagement.

@Trott Trott self-assigned this Sep 29, 2022
@daeyeon daeyeon added the meta Issues and PRs related to the general management of the project. label Sep 30, 2022
@bnb
Copy link
Contributor

bnb commented Oct 2, 2022

+1 @lukekarrys is great

@Trott
Copy link
Member

Trott commented Oct 7, 2022

This issue has been open for a week and the nomination is now accepted. I'll email @lukekarrys privately to schedule an onboarding.

@Trott
Copy link
Member

Trott commented Oct 7, 2022

Argh, I just noticed now that @nodejs/collaborators were not tagged on the nomination. So that's going to restart the one-week clock, but I'll still get something scheduled.

@MylesBorins
Copy link
Contributor Author

Argh, I just noticed now that https://github.com/orgs/nodejs/teams/collaborators were not tagged on the nomination. So that's going to restart the one-week clock, but I'll still get something scheduled.

oops, my bad 😓

@Trott
Copy link
Member

Trott commented Oct 14, 2022

The nomination passes. @lukekarrys has an onboarding session scheduled for Wednesday. More soon! 🎉

RafaelGSS pushed a commit that referenced this issue Nov 1, 2022
Fixes: #44828
PR-URL: #45180
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
RafaelGSS pushed a commit that referenced this issue Nov 10, 2022
Fixes: #44828
PR-URL: #45180
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
Fixes: #44828
PR-URL: #45180
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
danielleadams pushed a commit that referenced this issue Dec 30, 2022
Fixes: #44828
PR-URL: #45180
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
danielleadams pushed a commit that referenced this issue Jan 3, 2023
Fixes: #44828
PR-URL: #45180
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants