Skip to content

Server.closeIdleConnections break gc tests #43795

Closed
@F3n67u

Description

@F3n67u

Version

main

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

No response

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

No response

What do you see instead?

#43522 break a lot of tests, especially the gc-related test.

This issue is opened for TypeError: Cannot read properties of null (reading 'destroy') error. Ref to #43641 (comment) for why this error happened.

The Console output:

done/collected/total: 93/0/804
done/collected/total: 322/93/804
done/collected/total: 415/322/804
done/collected/total: 664/349/804
done/collected/total: 737/415/804
done/collected/total: 804/664/804
done/collected/total: 804/737/804
done/collected/total: 804/804/804
node:_http_server:498
    connections[i].socket.destroy();
                          ^

TypeError: Cannot read properties of null (reading 'destroy')
    at Server.closeIdleConnections (node:_http_server:498:27)
    at Server.close (node:_http_server:481:8)
    at Immediate.status (/home/iojs/build/workspace/node-test-binary-armv7l/test/parallel/test-gc-http-client-timeout.js:66:14)
    at process.processImmediate (node:internal/timers:471:21)

Node.js v19.0.0-pre

Tests affected by TypeError: Cannot read properties of null (reading 'destroy') error:

  1. sequential/test-gc-http-client-timeout
  2. sequential/test-gc-http-client
  3. sequential/test-gc-http-client-onerror

The below list is compiled from nodejs/reliability#320

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    flaky-testIssues and PRs related to the tests with unstable failures on the CI.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions