Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request-ci fails without error when CI is locked down #39746

Open
targos opened this issue Aug 12, 2021 · 4 comments
Open

request-ci fails without error when CI is locked down #39746

targos opened this issue Aug 12, 2021 · 4 comments
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.

Comments

@targos
Copy link
Member

targos commented Aug 12, 2021

See #39725 (comment)

The request-ci label was removed but the request-ci-failed label was not added.

I don't know what the Jenkins API responds in this case, but it doesn't seem like we handle it.

Workflow run: https://github.com/nodejs/node/runs/3296324085?check_suite_focus=true

@targos targos added build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. labels Aug 12, 2021
@targos
Copy link
Member Author

targos commented Aug 12, 2021

@nodejs/actions

@richardlau
Copy link
Member

We should handle the error but during a CI lockdown I think it's expected that request-ci would not start CI's.

@targos
Copy link
Member Author

targos commented Aug 12, 2021

during a CI lockdown I think it's expected that request-ci would not start CI's

agreed

@richardlau
Copy link
Member

I'm fairly certain this is a node-core-utils issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

No branches or pull requests

2 participants