node5: test-module-loading-error.js fails #3798

Activity

1. mscdex

   added

   moduleIssues and PRs related to the module subsystem.Issues and PRs related to the module subsystem.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   smartosIssues and PRs related to the SmartOS platform.Issues and PRs related to the SmartOS platform.

   on Nov 12, 2015
2. claudiorodriguez commented on Nov 16, 2015

   

   claudiorodriguez

   on Nov 16, 2015

   Contributor

   More actions

   Fix link is 404. Currently the test checks against 'unknown file type'. Which is the new error desc? Ideally it would check for both.
3. jelmd commented on Nov 16, 2015

   

   jelmd

   on Nov 16, 2015

   Author

   More actions

   Yeah, sorry, renamed to sunos.patch, because there are some other platform related nits. Just check the directory (s|test-sunos.patch||).
4. claudiorodriguez commented on Nov 16, 2015

   

   claudiorodriguez

   on Nov 16, 2015

   Contributor

   More actions

   I found a special case was already being evaluated for linux, so I just refactored the test to allow for expecting multiple possible error messages per platform.
5. claudiorodriguez commented on Nov 16, 2015

   

   claudiorodriguez

   on Nov 16, 2015

   Contributor

   More actions

   As for the other platform related nits, they're inside dependencies, so I'll let someone else handle that (a bit out of my confidence zone). You might want to create another issue for that.
6. evanlucas

   added a commit that references this issue on Nov 18, 2015

   test: module loading error fix solaris #3798

   ...

   9a628e2
7. MylesBorins

   added a commit that references this issue on Nov 30, 2015

   test: module loading error fix solaris #3798

   ...

   9827814
8. rvagg

   added 2 commits that reference this issue on Dec 4, 2015

   test: module loading error fix solaris #3798

   ...

   654192f

   test: module loading error fix solaris #3798

   ...

   f99c636
9. jasnell

   added 2 commits that reference this issue on Dec 17, 2015

   test: module loading error fix solaris #3798

   ...

   fb8df8d

   test: module loading error fix solaris #3798

   ...

   f1e64ba
10. bnoordhuis commented on Feb 12, 2016

    

    bnoordhuis

    on Feb 12, 2016

    Member

    More actions

    Closing, I'm fairly sure this was fixed in 9827814.
11. bnoordhuis

    closed this as completedon Feb 12, 2016