Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node5: test-module-loading-error.js fails #3798

Closed
jelmd opened this issue Nov 12, 2015 · 5 comments
Closed

node5: test-module-loading-error.js fails #3798

jelmd opened this issue Nov 12, 2015 · 5 comments
Labels
module Issues and PRs related to the module subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.

Comments

@jelmd
Copy link

jelmd commented Nov 12, 2015

test-module-loading-error.js fails on Solaris 11.3 because of expecting a historic? error message.
Fix: http://iws.cs.uni-magdeburg.de/~elkner/tmp/node5/test-sunos.patch
@mscdex mscdex added module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests. smartos Issues and PRs related to the SmartOS platform. labels Nov 12, 2015
@claudiorodriguez
Copy link
Contributor

Fix link is 404. Currently the test checks against 'unknown file type'. Which is the new error desc? Ideally it would check for both.

@jelmd
Copy link
Author

jelmd commented Nov 16, 2015

Yeah, sorry, renamed to sunos.patch, because there are some other platform related nits. Just check the directory (s|test-sunos.patch||).

@claudiorodriguez claudiorodriguez mentioned this issue Nov 16, 2015
Closed
@claudiorodriguez
Copy link
Contributor

I found a special case was already being evaluated for linux, so I just refactored the test to allow for expecting multiple possible error messages per platform.

@claudiorodriguez
Copy link
Contributor

As for the other platform related nits, they're inside dependencies, so I'll let someone else handle that (a bit out of my confidence zone). You might want to create another issue for that.

claudiorodriguez pushed a commit to claudiorodriguez/node that referenced this issue Nov 18, 2015
test: module loading error fix solaris nodejs#3798
4502899 
- refactor test to accept multiple error messages per platform
- add new message to be found in Solaris 11.3 as per nodejs#3798
evanlucas pushed a commit that referenced this issue Nov 18, 2015
@evanlucas
test: module loading error fix solaris #3798
9a628e2 
- refactor test to accept multiple error messages per platform
- add new message to be found in Solaris 11.3 as per #3798

PR-URL: #3855
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@Fishrock123 Fishrock123 mentioned this issue Nov 26, 2015
Closed
MylesBorins pushed a commit that referenced this issue Nov 30, 2015
test: module loading error fix solaris #3798
9827814 
- refactor test to accept multiple error messages per platform
- add new message to be found in Solaris 11.3 as per #3798

PR-URL: #3855
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
rvagg pushed a commit that referenced this issue Dec 4, 2015
@rvagg
test: module loading error fix solaris #3798
654192f 
- refactor test to accept multiple error messages per platform
- add new message to be found in Solaris 11.3 as per #3798

PR-URL: #3855
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
rvagg pushed a commit that referenced this issue Dec 5, 2015
@rvagg
test: module loading error fix solaris #3798
f99c636 
- refactor test to accept multiple error messages per platform
- add new message to be found in Solaris 11.3 as per #3798

PR-URL: #3855
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
This was referenced Dec 8, 2015
Closed
Merged
@jasnell jasnell mentioned this issue Dec 17, 2015
Closed
jasnell pushed a commit that referenced this issue Dec 17, 2015
@jasnell
test: module loading error fix solaris #3798
fb8df8d 
- refactor test to accept multiple error messages per platform
- add new message to be found in Solaris 11.3 as per #3798

PR-URL: #3855
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell pushed a commit that referenced this issue Dec 23, 2015
@jasnell
test: module loading error fix solaris #3798
f1e64ba 
- refactor test to accept multiple error messages per platform
- add new message to be found in Solaris 11.3 as per #3798

PR-URL: #3855
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@bnoordhuis
Copy link
Member

Closing, I'm fairly sure this was fixed in 9827814.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module Issues and PRs related to the module subsystem. smartos Issues and PRs related to the SmartOS platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @bnoordhuis @claudiorodriguez @jelmd