Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test parallel/test-blob in debug mode #37030

Closed
targos opened this issue Jan 23, 2021 · 0 comments · Fixed by #37052
Closed

flaky test parallel/test-blob in debug mode #37030

targos opened this issue Jan 23, 2021 · 0 comments · Fixed by #37052
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@targos
Copy link
Member

targos commented Jan 23, 2021

Example in CI: https://ci.nodejs.org/job/node-test-commit-linux-containered/24844/nodes=ubuntu1804_sharedlibs_debug_x64/testReport/

Fails ~40% of the runs on my machine:

Command: out/Debug/node /home/mzasso/git/nodejs/node/test/parallel/test-blob.js
--- CRASHED (Signal: 4) ---
[00:27|% 100|+  60|-  40]: Done

/cc @jasnell
@targos targos added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jan 23, 2021
jasnell added a commit to jasnell/node that referenced this issue Jan 24, 2021
@jasnell
buffer: avoid creating the backing store in the thread
bda7f8b 
Fixes: nodejs#37030
jasnell added a commit to jasnell/node that referenced this issue Jan 24, 2021
@jasnell
buffer: avoid creating the backing store in the thread
d205e50 
Fixes: nodejs#37030
@jasnell jasnell mentioned this issue Jan 24, 2021
Merged
jasnell added a commit to jasnell/node that referenced this issue Jan 24, 2021
@jasnell
buffer: avoid creating the backing store in the thread
15d37a3 
Fixes: nodejs#37030
@Trott Trott closed this as completed in da3a948 Jan 27, 2021
targos pushed a commit that referenced this issue Feb 2, 2021
@jasnell @targos
buffer: avoid creating the backing store in the thread
e4b88b5 
Fixes: #37030

PR-URL: #37052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Aug 8, 2021
@jasnell @targos
buffer: avoid creating the backing store in the thread
14ac0b1 
Fixes: nodejs#37030

PR-URL: nodejs#37052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Aug 8, 2021
@jasnell @targos
buffer: avoid creating the backing store in the thread
0325fcc 
Fixes: nodejs#37030

PR-URL: nodejs#37052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this issue Aug 13, 2021
@jasnell @targos
buffer: avoid creating the backing store in the thread
add1067 
Fixes: nodejs#37030

PR-URL: nodejs#37052
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this issue Aug 13, 2021
@jasnell @targos
buffer: avoid creating the backing store in the thread
5279827 
Fixes: #37030

PR-URL: #37052
Backport-PR-URL: #39704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this issue Aug 31, 2021
@jasnell @MylesBorins
buffer: avoid creating the backing store in the thread
8484ab2 
Fixes: #37030

PR-URL: #37052
Backport-PR-URL: #39704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this issue Oct 18, 2021
@jasnell @foxxyz
buffer: avoid creating the backing store in the thread
3c1a0f3 
Fixes: nodejs#37030

PR-URL: nodejs#37052
Backport-PR-URL: nodejs#39704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

buffer: avoid creating the backing store in the thread jasnell/node
1 participant
@targos