Repository navigation
Syntax error thrown for correct syntax within node shell #36513
Description
Activity
Are you able to test the proposed v14.15.2 release (#36476)? I suspect this may be addressed by the acorn parser related changes.
It appears to be fixed in 14.15.2
To make sure I followed the correct steps, this is how I tested:git clone https://github.com/nodejs/node.git cd node git fetch origin v14.15.2-proposal git checkout v14.15.2-proposal ./configure && make -j4 testOnce it was finished building, I found the path to the 14.15.2 version I just built
node_file_type="$(file -b "$(which node)" )" new_node_path="$(find ./out/Release \ -type f \ -name node \ -exec file {} + | \ grep "$node_file_type" | \ cut -d: -f1)" $new_node_path -vThen I used it to open a node shell and pasted the lines that failed in 14.15.1
$new_node_path const test1 = (value) => { return (value?.constructor); } const test2 = (value) => { return (value.constructor === Array) ? value : [value]; } const test3 = (value) => { return (value?.constructor) ? value : [value]; } const test4 = (value) => { return ((value?.constructor) === Array) ? value : [value]; } const test5 = (value) => { return ((value?.constructor) === Array) ? value : [value]; } const arr = new Array(); console.log(test5(arr))It did not throw an error.
Reacted by Richard LauShould be fixed in https://nodejs.org/en/blog/release/v14.15.2/.
The node shell does not correctly parse a multiline function that uses optional chaining, ternary operator, and an identity operator.
These commands work as expected
However, attempting to define function test5 from within a node shell fails