Cannot make a node-fetch request, TypeError: Cannot read property 'Symbol(requestOptions)' of undefined

[seven-deuce]

• Version: 14.15.1
• Platform: MINGW64_NT-10.0-17763 DESKTOP-GJB54B0 3.0.7-338.x86_64 2019-04-30 21:52 UTC x86_64 Msys
• Subsystem:

What steps will reproduce the bug?

Any call to foreign api, using a trusted library like "node-fetch", creates error and crash servers, on versions higher than 12.18
Here is the error:

_http_agent.js:444
      options = req[kRequestOptions];
                   ^

TypeError: Cannot read property 'Symbol(requestOptions)' of undefined
    at Agent.removeSocket (_http_agent.js:444:20)
    at TLSSocket.onClose (_http_agent.js:371:11)
    at TLSSocket.emit (events.js:327:22)
    at net.js:673:12
    at TCP.done (_tls_wrap.js:563:7)

How often does it reproduce? Is there a required condition?

All the time, not in version 12.18 or lower

What is the expected behavior?

a normal fetch, returning the result from any api, mostly a json

What do you see instead?

app crashes!

Additional information

[RaisinTen]

I'm having some difficulty reproducing this:

❯ cat index.js

const fetch = require('node-fetch');

(async () => {
	const response = await fetch('https://api.github.com/users/github');
	const json = await response.json();

	console.log(json);
})();

❯ node index.js &> /dev/null
❯ echo $?
0
❯ node -v
v15.2.0
❯ uname -a
Linux hp 4.15.0-124-generic #127-Ubuntu SMP Fri Nov 6 10:54:24 UTC 2020 i686 i686 i686 GNU/Linux

As you can see, it exits with a zero error code.

[seven-deuce]

I tracked down the issue and found out that one of the libs in the project, was defining methods on Object and Array Prototype.
When I removed it, it all started to work,
I wonder, what has changed after node v.12.18, that does not allow defining methods on Object/Array prototype??

[Trott]

I tracked down the issue and found out that one of the libs in the project, was defining methods on Object and Array Prototype.
When I removed it, it all started to work,
I wonder, what has changed after node v.12.18, that does not allow defining methods on Object/Array prototype??

This may be due to expanded use of what we call primordials on the project. The idea is that if a user changes the Object prototype, it should affect their code but not Node.js internal code. This is a security precaution but it may cause difficulty for people who "monkey-patch" Node.js internals like AMP vendors. I'd be curious to know what library is exhibiting this problem so we can track down whether this is expected breakage or a bug in Node.js that we need to fix.

[Trott]

I tracked down the issue and found out that one of the libs in the project, was defining methods on Object and Array Prototype.
When I removed it, it all started to work,
I wonder, what has changed after node v.12.18, that does not allow defining methods on Object/Array prototype??

This may be due to expanded use of what we call primordials on the project. The idea is that if a user changes the Object prototype, it should affect their code but not Node.js internal code. This is a security precaution but it may cause difficulty for people who "monkey-patch" Node.js internals like AMP vendors. I'd be curious to know what library is exhibiting this problem so we can track down whether this is expected breakage or a bug in Node.js that we need to fix.

Though it looks like @targos has already self-assigned this so they probably have a good idea what the bug is and what the fix is.