-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createReadStream/createWriteStream should support FileHandle #35240
Labels
feature request
Issues that request new features to be added to Node.js.
fs
Issues and PRs related to the fs subsystem / file system.
Comments
ronag
added
fs
Issues and PRs related to the fs subsystem / file system.
feature request
Issues that request new features to be added to Node.js.
labels
Sep 17, 2020
Any advantages over simply using |
Yes, closing the file handle would close the fd which would corrupt the stream, i.e. the reference counting is bypassed. |
Suddenly this appears much more needed, I will take it of no one is already working on it? |
@mmomtchev go for it! |
4 tasks
mmomtchev
added a commit
to mmomtchev/node
that referenced
this issue
Dec 2, 2020
Support creating a Read/WriteStream from a FileHandle instead of a raw file descriptor Add an EventEmitter to FileHandle with a single 'close' event Refs: nodejs#35240
mmomtchev
added a commit
to mmomtchev/node
that referenced
this issue
Dec 2, 2020
Add the PR URL to the documentation Refs: nodejs#35922 Refs: nodejs#35240
mmomtchev
added a commit
to mmomtchev/node
that referenced
this issue
Dec 2, 2020
Use primordials where necessary (@aduh95) and check that the data was actually written in the unit test Refs: nodejs#35922 Refs: nodejs#35240
cjihrig
pushed a commit
to cjihrig/node
that referenced
this issue
Dec 8, 2020
Support creating a Read/WriteStream from a FileHandle instead of a raw file descriptor Add an EventEmitter to FileHandle with a single 'close' event. Fixes: nodejs#35240 PR-URL: nodejs#35922 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
Issues that request new features to be added to Node.js.
fs
Issues and PRs related to the fs subsystem / file system.
Currently only raw file descriptors are supported. Should we allow for a
FileHandle
to be passed asfd
?The text was updated successfully, but these errors were encountered: