-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
investigate flaky parallel/test-trace-atomics-wait #35059
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
test
Issues and PRs related to the tests.
Comments
Trott
added
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
test
Issues and PRs related to the tests.
labels
Sep 4, 2020
Should the permutation above simply be added to the array of potential valid results? Or is that result a bug? @addaleax |
addaleax
added a commit
to addaleax/node
that referenced
this issue
Sep 5, 2020
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: nodejs#35059
3 tasks
Yeah, it’s a valid result – #35066 should fix this :) |
ruyadorno
pushed a commit
that referenced
this issue
Sep 17, 2020
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: #35059 PR-URL: #35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this issue
Jan 8, 2021
The two starting `Atomics.wait()` operations are not ordered, but the test assumed a specific ordering because of the latency that comes with spinning up a Worker thread. Add variants of the existing potential valid results that account for the reverse ordering. Fixes: nodejs#35059 PR-URL: nodejs#35066 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
test
Issues and PRs related to the tests.
What steps will reproduce the bug?
https://ci.nodejs.org/job/node-test-commit-osx/36076/nodes=osx1015/console
The text was updated successfully, but these errors were encountered: