Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate flaky parallel/test-trace-atomics-wait #35059

Closed
Trott opened this issue Sep 4, 2020 · 2 comments
Closed

investigate flaky parallel/test-trace-atomics-wait #35059

Trott opened this issue Sep 4, 2020 · 2 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Sep 4, 2020

  • Version: v15.0-pre (current master branch)
  • Platform: macOS 10.15
  • Subsystem: test

What steps will reproduce the bug?

https://ci.nodejs.org/job/node-test-commit-osx/36076/nodes=osx1015/console

06:28:40 not ok 2273 parallel/test-trace-atomics-wait
06:28:40   ---
06:28:40   duration_ms: 0.211
06:28:40   severity: fail
06:28:40   exitcode: 1
06:28:40   stack: |-
06:28:40     +++ normalized stdout +++
06:28:40     [Thread 0] Atomics.wait(<address> + 0, 1, inf) started
06:28:40     [Thread 0] Atomics.wait(<address> + 0, 1, inf) did not wait because the values mismatched
06:28:40     [Thread 0] Atomics.wait(<address> + 0, 0, 10) started
06:28:40     [Thread 0] Atomics.wait(<address> + 0, 0, 10) timed out
06:28:40     [Thread 1] Atomics.wait(<address> + 4, -1, inf) started
06:28:40     [Thread 0] Atomics.wait(<address> + 4, 0, inf) started
06:28:40     [Thread 0] Atomics.wait(<address> + 4, 0, inf) did not wait because the values mismatched
06:28:40     [Thread 1] Atomics.wait(<address> + 4, -1, inf) was woken up by another thread
06:28:40     --- normalized stdout ---
06:28:40     assert.js:385
06:28:40         throw err;
06:28:40         ^
06:28:40     
06:28:40     AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
06:28:40     
06:28:40       assert(expectedTimelines.includes(actualTimeline))
06:28:40     
06:28:40         at Object.<anonymous> (/Users/iojs/build/workspace/node-test-commit-osx/nodes/osx1015/test/parallel/test-trace-atomics-wait.js:84:1)
06:28:40         at Module._compile (internal/modules/cjs/loader.js:1090:30)
06:28:40         at Object.Module._extensions..js (internal/modules/cjs/loader.js:1111:10)
06:28:40         at Module.load (internal/modules/cjs/loader.js:955:32)
06:28:40         at Function.Module._load (internal/modules/cjs/loader.js:796:14)
06:28:40         at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
06:28:40         at internal/main/run_main_module.js:17:47 {
06:28:40       generatedMessage: true,
06:28:40       code: 'ERR_ASSERTION',
06:28:40       actual: false,
06:28:40       expected: true,
06:28:40       operator: '=='
06:28:40     }
06:28:40   ...
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Sep 4, 2020
@Trott
Copy link
Member Author

Trott commented Sep 4, 2020

Should the permutation above simply be added to the array of potential valid results? Or is that result a bug? @addaleax

addaleax added a commit to addaleax/node that referenced this issue Sep 5, 2020
The two starting `Atomics.wait()` operations are not ordered,
but the test assumed a specific ordering because of the latency
that comes with spinning up a Worker thread.

Add variants of the existing potential valid results that account
for the reverse ordering.

Fixes: nodejs#35059
@addaleax
Copy link
Member

addaleax commented Sep 5, 2020

Yeah, it’s a valid result – #35066 should fix this :)

ruyadorno pushed a commit that referenced this issue Sep 17, 2020
The two starting `Atomics.wait()` operations are not ordered,
but the test assumed a specific ordering because of the latency
that comes with spinning up a Worker thread.

Add variants of the existing potential valid results that account
for the reverse ordering.

Fixes: #35059

PR-URL: #35066
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this issue Jan 8, 2021
The two starting `Atomics.wait()` operations are not ordered,
but the test assumed a specific ordering because of the latency
that comes with spinning up a Worker thread.

Add variants of the existing potential valid results that account
for the reverse ordering.

Fixes: nodejs#35059

PR-URL: nodejs#35066
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants