Skip to content

fs.realpath.native causes SIGABRT on darwin when the realpath is really long #34900

Closed
Closed
fs.realpath.native causes SIGABRT on darwin when the realpath is really long#34900
Labels
libuvIssues and PRs related to the libuv dependency or the uv binding.macosIssues and PRs related to the macOS platform.

Description

@ashi009
ashi009
opened on Aug 24, 2020
  • Version: v12.12.0 and v14.8.0
  • Platform: Darwin Kernel Version 19.6.0: Sun Jul 5 00:43:10 PDT 2020; root:xnu-6153.141.1~9/RELEASE_X86_64
  • Subsystem: fs

What steps will reproduce the bug?

$ LONG_PATH='/tmp/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/long/path/254B'
$ SHORT_LINK='/tmp/short'
$ mkdir -p "${LONG_PATH}"
$ ln -s "${LONG_PATH}" "${SHORT_LINK}"
$ node -e "fs.realpathSync.native('${SHORT_LINK}/file-not-exist')"
node(60274,0x10eabedc0) malloc: Incorrect checksum for freed object 0x104805aa0: probably modified after being freed.
Corrupt value: 0x7473697865
node(60274,0x10eabedc0) malloc: *** set a breakpoint in malloc_error_break to debug
Abort trap: 6

How often does it reproduce? Is there a required condition?

Almost every time.

What is the expected behavior?

return ENOENT.

What do you see instead?

Crash with SIGABRT

Additional information

The bug is confirmed by the libuv and the patch is underway: libuv/libuv#2965

Activity

  1. bnoordhuis commented on Aug 24, 2020

    @bnoordhuis
    bnoordhuis
    on Aug 24, 2020
    Member

    After the patch, the buffer overrun threshold should be 1025 on darwin

    To clarify: there's no buffer overrun anymore after libuv/libuv#2965 lands because paths are never > 1024 on that platform.

    The problem was that libuv was using the wrong constant, one that was considerably smaller.

  2. ashi009 commented on Aug 24, 2020

    @ashi009
    ashi009
    on Aug 24, 2020
    Author

    After the patch, the buffer overrun threshold should be 1025 on darwin

    To clarify: there's no buffer overrun anymore after libuv/libuv#2965 lands because paths are never > 1024 on that platform.

    The problem was that libuv was using the wrong constant, one that was considerably smaller.

    Correct, I'll scratch the last bit.

  3. silverwind
    added
    macosIssues and PRs related to the macOS platform.
    libuvIssues and PRs related to the libuv dependency or the uv binding.
    on Aug 25, 2020

  4. bnoordhuis commented on Aug 27, 2020

    @bnoordhuis
    bnoordhuis
    on Aug 27, 2020
    Member

    This was fixed by the libuv upgrade in #34915 and is scheduled for release today, see #34852.

    I don't know exactly when it'll be back-ported to v12.x and v10.x, that's up to the @nodejs/releasers.

  5. bnoordhuis
    closed this as completedon Aug 27, 2020
  6. BethGriggs
    added
    lts-watch-v10.x
    lts-watch-v12.x
    on Aug 27, 2020

  7. richardlau commented on Mar 17, 2021

    @richardlau
    richardlau
    on Mar 17, 2021
    Member

    The libuv update from #34915 went out in Node.js 12.19.0 (#35401).

  8. richardlau
    removed
    lts-watch-v12.x
    on Mar 17, 2021

  9. richardlau commented on Mar 17, 2021

    @richardlau
    richardlau
    on Mar 17, 2021
    Member

    At this late stage it's very unlikely libuv will be updated again in Node.js 10.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    libuvIssues and PRs related to the libuv dependency or the uv binding.macosIssues and PRs related to the macOS platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions