Tracking Issue: commit queue issues and feedback

[mmarchini]

commit-queue can be used to land pull requests. It is still experimental, so when using please remember to check if the Pull Request landed successfully. Please share any failed landings here so we can keep track of issues, our landing process is quite complex and full of edge cases, we'll need to tweak the commit-queue and node-core-utils before we can consider this feature stable.

I'll keep this issue updated with all known issues.

• Commits pushed since last review (buffer: alias UInt ➡️ Uint in buffer methods #34729 (comment))
  • IMO it's fine to request the lander to approve the PR before adding the label
• Missing CI on doc-only changes with successful Actions run (buffer: alias UInt ➡️ Uint in buffer methods #34729 (comment))
• Doesn't work with multiple commits in a PR
• Doesn't work with fixup and squash commits
• Don't land PRs that should be landed manually (manual-land label)
• Can't land DEPXXX (doc: add missing DEP ID for 'new crypto.Certificate()' #34940) (Won't fix, see tools: lint deprecation codes #41992)
• If the newest Jenkins job run is a run that was deleted on Jenkins, the commit queue skips instead of failing
  • But if CI ran on Jenkins and other job was deleted (like CITGM or benchmark), it should succeed
• Should skip if GitHub Actions still running
• Action fails without setting label if local is not sync'ed with remote (which should only happen as a race condition). Should retry instead.
• Land purple
• Don't try to land commits with changes to .github/workflows
• Rewrite in JS
• Try/catch functionality (ensure -failed label is added when something fails)

[mmarchini]

Tried two pull requests, both failed:

• Commits pushed since last review (buffer: alias UInt ➡️ Uint in buffer methods #34729 (comment))
• Missing CI on doc-only changes with successful Actions run (buffer: alias UInt ➡️ Uint in buffer methods #34729 (comment))

[lundibundi]

Simple cases of two last points may be fixed with
nodejs/node-core-utils#473

[lundibundi]

🤔 Anyone knows why but these PRs failed to apply patches:
#34997 (comment)
#34682 (comment)

even though locally it applied successfully with manual git node land. Is three-way-merge somehow disabled for commit-queue?

[mmarchini]

We should add a link to the Action in the bot comment: so we don't have to go chasing it every time it fails: https://github.com/nodejs/node/runs/1102351422?check_suite_focus=true

As for the failures, I'm not entirely sure, it should've worked 🤔

One thing to do when this happens is to run git node land with --yes locally, since that's how it runs on the commit queue. This will ensure we're running the same command. Maybe ncu doesn't go to 3-way-merge with --yes? It should, but there might be a bug.

[mmarchini]

Should wait for GitHub Actions to finish running as well: #35160 (comment)

[aduh95]

Any idea why #34951 is skipped?

[mmarchini]

We have quite a backlog of scheduled Actions for the past hour, so something is up with GitHub apparently:

@aduh95 ncu thinks the CI is still running. Since the label was added four days ago, it's unrelated to the security release lockdown, but I can't check the CI status now because of the lockdown. If I forget to look at it tomorrow after the lockdown is lifted, feel free to ping me.

[targos]

In #33770 (comment), a PR with 3 commits, the bot commented only with the last commit hash, instead of a range.