Make EventTarget Spec Compliant

[Ethan-Arrowood]

Based on #34074 this issue tracks improving the internal EventTarget implementation to be achieve spec compliance.

From a previous comment these are some initial action items:

• Add WPT.
• Add other tests.
• Go over the spec and fix deltas (and add tests)

Unless there is a better spec document I plan on using this one as reference: https://dom.spec.whatwg.org/#interface-eventtarget

WPT: https://github.com/web-platform-tests/wpt/tree/master/dom/events
EventEmitter vs EventTarget: https://docs.google.com/document/d/1NFARs04-4U_2y6Ssw9Lqu1GMXBUM981-NO9PLJWifTI/edit#

[Ethan-Arrowood]

WPT branch: https://github.com/Ethan-Arrowood/node/tree/add-event-target-wpt

@benjamingr how do I add Events and EventTarget to global object for the test-events.js file?

[benjamingr]

@benjamingr how do I add Events and EventTarget to global object for the test-events.js file?

You can just put them on global at the start of the test - though I would probably manually port the tests since the WPTs rely heavily on other parts of the DOM (like Element) being present

[Ethan-Arrowood]

I followed the WPT guide found at /node/test/wpt/README.md and did the whole git node wpt dom/events thing. Should I now go test by test and modify them to fit Node? Or when you say manual do you mean not doing this method at all and just rewriting these tests one by one?

[benjamingr]

@Ethan-Arrowood I tried that route and it didn't work. I meant not use git node wpt and port the tests manually (to /tests/parallel) because the browser DOM tests use window

[Ethan-Arrowood]

Ah I see, okay sounds good I'll scrap this stuff then and begin the conversion. Would you like me to put up a pr when I have some or all of them done?

[benjamingr]

Sure, that would be helpful :]

[Ethan-Arrowood]

First test added @benjamingr draft pr #34169 - more will come soon 😄

[benjamingr]

Hey, any status/updates on this?

[Ethan-Arrowood]

I'll pin the open PR and give it some attention soon

[benjamingr]

OK, let me know if you need any help with specifics.

[Ethan-Arrowood]

Okay i've updated that pr, hopefully it can be merged soon.

@benjamingr do you have any ideas how I can be more organized in writing more WPT tests for this? The last time I tried writing more of them I realized a lot didn't really apply to Node (since they were very much DOM based).

Together if we could compile a list of all the tests that would need to be transferred over id be happy to start making my way through them 😁

[benjamingr]

Port things that are Node based to be EventEmitter based probably