Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --error-on-warn to vcbuild.bat #33158

Closed
danbev opened this issue Apr 30, 2020 · 2 comments
Closed

Add --error-on-warn to vcbuild.bat #33158

danbev opened this issue Apr 30, 2020 · 2 comments
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. stale windows Issues and PRs related to the Windows platform.

Comments

@danbev
Copy link
Contributor

danbev commented Apr 30, 2020

Is your feature request related to a problem? Please describe.
Add the --error-on-warn flag that was introduced in #32685 to vcbuild.bat

Describe the solution you'd like
When --error-on-warn flag is specified any compiler warnings should fail the build.
@targos targos added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. feature request Issues that request new features to be added to Node.js. labels Dec 27, 2020
jasnell added a commit to jasnell/node that referenced this issue May 12, 2021
@jasnell
build: support error-on-warn in vcbuild
f36fc1c 
Fixes: nodejs#33158
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell mentioned this issue May 12, 2021
Closed
@github-actions
Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Mar 18, 2022
@targos targos moved this to Pending Triage in Node.js feature requests Mar 19, 2022
@targos targos moved this from Pending Triage to Stale in Node.js feature requests Mar 19, 2022
@github-actions
Copy link
Contributor

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js. stale windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: support error-on-warn in vcbuild jasnell/node
2 participants
@danbev @targos