Node 14 with warning (node:31518) Warning: Accessing non-existent property 'column' of module exports inside circular dependency

[gengjiawen]

• Version: Node.js 14.0
• Platform: mac 10.15.3
• Subsystem:

Happens in lots of library I use.

What steps will reproduce the bug?

Repo:
https://github.com/gengjiawen/sample
CI:
https://github.com/gengjiawen/sample/runs/607139469?check_suite_focus=true#step:4:113

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior?

no warning

What do you see instead?

(node:32751) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:32751) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency
(node:32751) Warning: Accessing non-existent property 'lineno' of module exports inside circular dependency
(node:32751) Warning: Accessing non-existent property 'column' of module exports inside circular dependency
(node:32751) Warning: Accessing non-existent property 'filename' of module exports inside circular dependency

Additional information

cc @nodejs/modules-active-members

[gengjiawen]

After I updated my deps, vue project looks fixe.
But looks still exist like in jessety/pm2-installer#3

[himself65]

because this pr only landed in node.js v14.0.0

this must be a SEMVER-MAJOR but not in the update docs

cc @nodejs/releasers

[gengjiawen]

@addaleax Can this warning be more friendly, like telling me which module cause the problem.

[himself65]

@gengjiawen we do have the way to display which module cause the problem

use --trace-warnings, not friendly for the user, the many unnecessary stacks

>node --trace-warnings a
(node:19168) Warning: Accessing non-existent property 'foo' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:814:11)
    at Object.get (internal/modules/cjs/loader.js:825:5)
    at Object.<anonymous> (C:\Users\Himself65\Desktop\github\test\cycle\c.js:4:10)
    at Module._compile (internal/modules/cjs/loader.js:1185:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1205:10)
    at Module.load (internal/modules/cjs/loader.js:1034:32)
    at Function.Module._load (internal/modules/cjs/loader.js:923:14)
    at Module.require (internal/modules/cjs/loader.js:1074:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (C:\Users\Himself65\Desktop\github\test\cycle\b.js:1:1)

another problem is that we not telling this in the v14 docs.

[gengjiawen]

For anyone run into similar issue, npx cross-env NODE_OPTIONS="--trace-warnings" yarn build this may help you.

[addaleax]

Right, I’m surprised that #32797 was not released in 14.0.0. I assumed that it would be, as it was on v14.x-staging before the release. It should be included in the next one, though. /cc @BethGriggs

[richardlau]

Right, I’m surprised that #32797 was not released in 14.0.0. I assumed that it would be, as it was on v14.x-staging before the release. It should be included in the next one, though. /cc @BethGriggs

It was included (via 1092bb9): https://github.com/nodejs/node/commits/v14.0.0?after=73aa21658dfa6a22c06451d080152b32b1f98dbe+42

[gengjiawen]

Right, I’m surprised that #32797 was not released in 14.0.0. I assumed that it would be, as it was on v14.x-staging before the release. It should be included in the next one, though. /cc @BethGriggs

It's included in release too. Full console log include this (the log is very long, I am not noticed it in first place, thanks @himself65 pointed out).

Maybe joining this (Use 'node --trace-warnings ...' to show where the warning was created) with first warning to make the logic connection more strong ?

(node:2658) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:2658) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency

[addaleax]

I guess there might be a bug in #32797 then, it is supposed to show the hint after the first warning

[gengjiawen]

I think this is the line ?

In issue description the log is not complete, you need to click the CI link.