Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky parallel/test-child-process-fork-args on Windows #32863

Closed
puzpuzpuz opened this issue Apr 15, 2020 · 10 comments
Closed

Flaky parallel/test-child-process-fork-args on Windows #32863

puzpuzpuz opened this issue Apr 15, 2020 · 10 comments
Labels
child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@puzpuzpuz
Copy link
Member

Saw this test crashing in node-test-binary-windows-js-suites on https://ci.nodejs.org/job/node-test-pull-request/30753/:

12:59:01 not ok 70 parallel/test-child-process-fork-args
12:59:01   ---
12:59:01   duration_ms: 0.305
12:59:01   severity: crashed
12:59:01   exitcode: -1073741819
12:59:01   stack: |-
12:59:01   ...
@puzpuzpuz puzpuzpuz added child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Apr 15, 2020
@puzpuzpuz puzpuzpuz changed the title Flaky test/parallel/test-child-process-fork-args on Windows Flaky parallel/test-child-process-fork-args on Windows Apr 15, 2020
@addaleax
Copy link
Member

Fwiw, I tried to reproduce this locally, but failed both on Linux and Windows. :/

@puzpuzpuz
Copy link
Member Author

Fwiw, I tried to reproduce this locally, but failed both on Linux and Windows. :/

From what I can find on the internet, -1073741819 application exit code on Windows means Access Violation exception, which is a generic error. So, it may be related with something specific in CI machine environment.

If I encounter this failure once again, I'll post an update here.

@targos
Copy link
Member

targos commented Apr 20, 2020

Happened here too: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/3321/

@sam-github
Copy link
Contributor

Can we mark it as flaky to get CI stable? (This issue would remain open).

@puzpuzpuz
Copy link
Member Author

Can we mark it as flaky to get CI stable? (This issue would remain open).

Created #32950 to mark it as flaky

@puzpuzpuz puzpuzpuz added the windows Issues and PRs related to the Windows platform. label Apr 21, 2020
puzpuzpuz added a commit that referenced this issue Apr 21, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 27, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BridgeAR pushed a commit that referenced this issue Apr 28, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this issue Apr 30, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this issue May 13, 2020
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 8, 2020

I'm not finding this error with ncu-ci walk commit and no one has reported it here since April (but that may just be because it's been marked flaky so people ignore it failing).

I'll run a stress test. If that passes, I'll open a PR to optimistically remove the flaky designation.

@Trott
Copy link
Member

Trott commented Aug 8, 2020

@Trott
Copy link
Member

Trott commented Aug 8, 2020

Stress test was green. PR to remove this from flaky tests; #34684

@vweevers
Copy link
Contributor

vweevers commented Aug 9, 2020

no one has reported it here since April

The exit code 1073741819 has been seen on AppVeyor builds too (of sharp, sqlite3, prebuild-install, native-hdr-histogram) with 32-bit node when running npm run * or even just npm -v. This bug disappears and reappears with new node releases. 14.0.0 had it, 14.1.0 and 14.2.0 did not, 14.3.0 did, 14.7.0 did.

I'm not sure it's the same issue, so I wanted to investigate before reporting but I haven't had the time to do so.

See appveyor/ci#3407 (comment)

@Trott Trott closed this as completed in ea5eb8f Aug 11, 2020
MylesBorins pushed a commit that referenced this issue Aug 17, 2020
test-child-process-fork-args does not appear in results from `ncu-ci
walk commit` and no one has reported it failing for several months.
A stress test also passed.

Closes: #32863

PR-URL: #34684
Fixes: #32863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
BethGriggs pushed a commit that referenced this issue Aug 20, 2020
test-child-process-fork-args does not appear in results from `ncu-ci
walk commit` and no one has reported it failing for several months.
A stress test also passed.

Closes: #32863

PR-URL: #34684
Fixes: #32863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
test-child-process-fork-args does not appear in results from `ncu-ci
walk commit` and no one has reported it failing for several months.
A stress test also passed.

Closes: #32863

PR-URL: #34684
Fixes: #32863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
addaleax pushed a commit that referenced this issue Sep 22, 2020
test-child-process-fork-args does not appear in results from `ncu-ci
walk commit` and no one has reported it failing for several months.
A stress test also passed.

Closes: #32863

PR-URL: #34684
Fixes: #32863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Pranshu Srivastava <rexagod@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants