Erbium: test regression in tarball

[ArchangeGabriel]

• Version: 12.6.2
• Platform: Linux

What steps will reproduce the bug?

curl -O "https://nodejs.org/dist/v12.6.2/node-v12.6.2.tar.xz"
tar xf node-v12.6.2.tar.xz
cd node-v12.6.2
./configure
make
make tests

How often does it reproduce? Is there a required condition?

Always.

What is the expected behavior?

Tests suite runs fine.

What do you see instead?

make -s test-doc
Linting is not available through the source tarball.
Use the git repo instead: git clone https://github.com/nodejs/node.git
added 105 packages in 1.477s
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:757: out/doc/api/async_hooks.html] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:757: out/doc/api/addons.html] Error 1
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:757: out/doc/api/assert.html] Error 1
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:757: out/doc/api/child_process.html] Error 1
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:757: out/doc/api/buffer.html] Error 1
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:757: out/doc/api/cli.html] Error 1
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:757: out/doc/api/cluster.html] Error 1
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}
make[2]: *** [Makefile:757: out/doc/api/console.html] Error 1
internal/modules/cjs/loader.js:983
  throw err;
  ^

Error: Cannot find module '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/../node_modules/eslint/node_modules/js-yaml'
Require stack:
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js
- /build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:980:15)
    at Function.Module._load (internal/modules/cjs/loader.js:862:27)
    at Module.require (internal/modules/cjs/loader.js:1042:19)
    at require (internal/modules/cjs/helpers.js:77:18)
    at Object.<anonymous> (/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js:4:3)
    at Module._compile (internal/modules/cjs/loader.js:1156:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
    at Module.load (internal/modules/cjs/loader.js:1000:32)
    at Function.Module._load (internal/modules/cjs/loader.js:899:14)
    at Module.require (internal/modules/cjs/loader.js:1042:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/common.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/html.js',
    '/build/nodejs-lts-erbium/src/node-v12.16.2/tools/doc/generate.js'
  ]
}

Additional information

Seems to me as a regression of the fixed #7201. But I don’t know node enough to assess that with certainty.

[ArchangeGabriel]

Same issue is present with Dubnium 10.20.1 tarball, but wasn’t in 10.20.0. I suppose that the inclusion of linting modules is part of the unexpected content of the first tarball?

[mijutu]

Same issue with 14.2.0

[targos]

Is this really an issue? I'm not certain we need to be able to run the linter from the source tarball?

[ArchangeGabriel]

As a distro packager it is important for me to be able to run successfully the test suite of the software I package.

I agree that running the linter for source releases does not really matter, as this is definitively not supposed to be system-dependent. Maybe those tests should be disabled in the tarball then? (I’m already doing that as a workaround in my recipe, i.e. sed -i '/\$(MAKE) -s test-doc/d' Makefile)

[targos]

./configure && make test-only is what works for the tarball. It skips the linter. I just tried with v14.15.3 and it works fine.

[ArchangeGabriel]

@targos Thanks, that’s perfect.