Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test-debugger fails hard, amirite? #3156

Closed
Trott opened this issue Oct 2, 2015 · 4 comments
Closed

make test-debugger fails hard, amirite? #3156

Trott opened this issue Oct 2, 2015 · 4 comments
Labels
test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Oct 2, 2015

make test-debugger results in 8 out of 10 tests failing (current master branch on OS X 10.10.5). This isn't just me, is it? And if not, are these tests worth salvaging or should they be removed?

@Trott Trott added the test Issues and PRs related to the tests. label Oct 2, 2015
@mscdex mscdex added the debugger label Oct 2, 2015
@targos
Copy link
Member

targos commented Oct 2, 2015

Same on Fedora 22 (8 fails / 10)

@bnoordhuis
Copy link
Member

I've wasted a disproportionate amount of time on them over the years and won't be sad to seem them go, FWIW.

@Trott
Copy link
Member Author

Trott commented Feb 11, 2016

For what it's worth, it appears that we now have it down to 6 of 10 tests failing. Progress, I guess.

Trott added a commit to Trott/io.js that referenced this issue Mar 2, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: nodejs#3156
Refs: nodejs@c16963b9
jasnell pushed a commit that referenced this issue Mar 7, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: #3156
Refs: c16963b9
PR-URL: #5532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Fishrock123 pushed a commit that referenced this issue Mar 8, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: #3156
Refs: c16963b9
PR-URL: #5532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
Fishrock123 pushed a commit that referenced this issue Mar 8, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: #3156
Refs: c16963b9
PR-URL: #5532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: #3156
Refs: c16963b9
PR-URL: #5532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: #3156
Refs: c16963b9
PR-URL: #5532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
`test-debug-break-on-uncaught` was hanging on the domain and parse error
scenarios. These tests are not run in CI and may have been broken
for a very long time.

Refs: #3156
Refs: c16963b9
PR-URL: #5532
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <r@va.gg>
@Trott
Copy link
Member Author

Trott commented Apr 4, 2017

Debugger is going to be removed in the foreseeable future. These tests are unlikely to be repaired. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

4 participants