Skip to content

CI: introduce github actions #31017

Closed
Closed
@gengjiawen

Description

We already has travis-CI for basic CI, why introduce another one ?

There are a few reasons.

  • Github actions has better github integrations. Travis CI has to be enabled by project maintainer.Like https://github.com/nodejs/quic, you have to go to travis website to make it work, orgnization members won't has the permission. If we has this, futher experimental projects CI part should be easy.

  • Github action support linux, macOS, windows. I am thinking introduce build steps on all three platforms. This should make build problem found more early. (Like quic: initial experimental quic implementation #30943, works on linux, but not on macOS). Maybe only execute test on one platform.

  • Github action machine config is good than others, macOS has

  System:
    OS: macOS 10.15.1
    CPU: (4) x64 Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz
    Memory: 8.21 GB / 12.00 GB

We already has Github actions in https://github.com/cjihrig/uvwasi and https://github.com/nodejs/node-gyp.

Even if we decide to maintain travis and github actions simultaneously (which is very common), still worth it.

cc @nodejs/build @cclauss

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions