-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: introduce github actions #31017
Comments
There was this previous PR FWIW. |
One thing I have not seen solved via github actions is a good way at looking at the output of a test suite. Is there a decent solution from that aside from digging through the logs? |
In Actions output, each build step is below a twisty and only build steps that have failed have their twisty open. So if you create lots of job step then there is no digging required to find the failure. |
@cclauss Any thought on reopen your PR ? |
Thought on make one of the PRs support windows and macOS too ? |
Sure. Go for it. |
I'm broadly in favour of trying things on GitHub actions. A couple of concerns:
|
I had never noticed that! In retrospect, its because I don't even try to run |
I would like to be involved maintain github action. Feel free to @ me when there is related issue. |
My intention is only to try build tasks. So I opened a new PR: #31153. |
close for #31153 is merged. |
We already has travis-CI for basic CI, why introduce another one ?
There are a few reasons.
Github actions has better github integrations. Travis CI has to be enabled by project maintainer.Like https://github.com/nodejs/quic, you have to go to travis website to make it work, orgnization members won't has the permission. If we has this, futher experimental projects CI part should be easy.
Github action support linux, macOS, windows. I am thinking introduce build steps on all three platforms. This should make build problem found more early. (Like quic: initial experimental quic implementation #30943, works on linux, but not on macOS). Maybe only execute test on one platform.
Github action machine config is good than others, macOS has
We already has Github actions in https://github.com/cjihrig/uvwasi and https://github.com/nodejs/node-gyp.
Even if we decide to maintain travis and github actions simultaneously (which is very common), still worth it.
cc @nodejs/build @cclauss
The text was updated successfully, but these errors were encountered: