-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8::ArrayBuffer::New() without a BackingStore is deprecated in V8 8.0 #30529
Comments
I would like to work on this issue. |
@thangktran Cool! This is quite C++-heavy, so it helps if you’re familiar with that. I would recommend starting by looking at If you have any questions or need help getting started, feel free to comment here, or ask the |
@addaleax Thank you for your suggestion. |
EDIT: I figured it out. I'll test it and keep you update. |
There appears to be a bug in v8. |
@thangktran Yeah, thanks for reporting that 👍 |
ArrayBuffer without BackingStore will soon be deprecated. Fixes:nodejs#30529
The new API is present in V8 7.9, so we can already migrate to it:
node/deps/v8/include/v8.h
Lines 5007 to 5043 in b551c65
There is an upstream issue to gather feedback: v8:9908.
The text was updated successfully, but these errors were encountered: