Skip to content

test/doctool/test-doctool-html requires internet connection? #29918

Closed
#30214
Closed
test/doctool/test-doctool-html requires internet connection?#29918
#30214
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.docIssues and PRs related to Node.js documentation.toolsIssues and PRs related to the tools directory.

Description

@joyeecheung
joyeecheung
opened on Oct 10, 2019

I got this today:

/Applications/Xcode.app/Contents/Developer/usr/bin/make -s test-doc
Running JS linter...
Running C++ linter...
Running Markdown linter on misc docs...
Running Markdown linter on docs...
=== release test-doctool-html ===
Path: doctool/test-doctool-html
Failed to add alternative version links to foo
Failed to add alternative version links to foo
Failed to add alternative version links to foo
Failed to add alternative version links to foo
/Users/joyee/projects/node/test/common/index.js:710
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: connect ETIMEDOUT 151.101.228.133:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1128:14) {
  errno: -60,
  code: 'ETIMEDOUT',
  syscall: 'connect',
  address: '151.101.228.133',
  port: 443
}
Command: out/Release/node /Users/joyee/projects/node/test/doctool/test-doctool-html.js
[01:17|% 100|+   3|-   1]: Done
make[1]: *** [test-doc] Error 1
make: *** [test] Error 2

And if I turn off Wifi..

NODE_DEBUG=net out/Release/node /Users/joyee/projects/node/test/doctool/test-doctool-html.js
Failed to add alternative version links to foo
Failed to add alternative version links to foo
NET 34507: pipe false null
NET 34507: connect: find host raw.githubusercontent.com
NET 34507: connect: dns options { family: undefined, hints: 1024 }
NET 34507: _read
NET 34507: _read wait for connection
Failed to add alternative version links to foo
Failed to add alternative version links to foo
NET 34507: destroy
NET 34507: close
NET 34507: close handle
/Users/joyee/projects/node/test/common/index.js:710
const crashOnUnhandledRejection = (err) => { throw err; };
                                             ^

Error: getaddrinfo ENOTFOUND raw.githubusercontent.com
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:60:26) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'raw.githubusercontent.com'
}

Has there been any changes that add this new requirement? It seems weird to require internet connection to run the doc tests.

Activity

  1. richardlau commented on Oct 10, 2019

    @richardlau
    richardlau
    on Oct 10, 2019
    Member

    Has there been any changes that add this new requirement? It seems weird to require internet connection to run the doc tests.

    #27661

  2. joyeecheung
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    docIssues and PRs related to Node.js documentation.
    toolsIssues and PRs related to the tools directory.
    on Oct 11, 2019

  3. joyeecheung commented on Oct 11, 2019

    @joyeecheung
    joyeecheung
    on Oct 11, 2019
    MemberAuthor

    cc @nodejs/testing

    @richardlau Thanks for the pointer. Can we use something in the file system instead? (That is to go back to what #27661 originally did, cc @BridgeAR ). In my opinion, the default test suites should not require an Internet connection , otherwise it should be placed under test/internet - not every access point guarantees stable, unpolluted connection to raw.githubusercontent.com and requiring the connection to it in the default test suite leads to false failures that have nothing to do with the code.

  4. richardlau commented on Oct 11, 2019

    @richardlau
    richardlau
    on Oct 11, 2019
    Member

    It's not the test suite but the actual doctool that is making the connection (the test added by that PR was placed in internet but obviously with hindsight existing tests that ran the tool were affected). Also doctool tests are not in the default set of test suites.

    I guess the question is whether we care whether or not that the API docs can point to a newer release line? e.g. the 12.x docs pointing to the 13.x equivalent in the "View another version" drop down -- the issue with the file system is the changelog in the 12.x branch will not have a reference to 13.x (even after it is released as we don't backport those kinds of changes).

    Open to any suggestions. The original aim of #27661 was to reduce the manual effort in keeping the version picker in the docs accurate.

  5. Trott commented on Oct 15, 2019

    @Trott
    Trott
    on Oct 15, 2019 · Hidden as outdated

  6. Trott commented on Oct 15, 2019

    @Trott
    Trott
    on Oct 15, 2019 · Hidden as outdated

  7. Trott commented on Oct 15, 2019

    @Trott
    Trott
    on Oct 15, 2019 · Hidden as outdated

  8. Trott commented on Oct 15, 2019

    @Trott
    Trott
    on Oct 15, 2019 · Hidden as outdated

  9. joyeecheung commented on Nov 2, 2019

    @joyeecheung
    joyeecheung
    on Nov 2, 2019
    MemberAuthor

    I am preparing for the code and learn tomorrow and I noticed that this may cause issues with the conference WiFi where connections to raw.githubusercontent.com result in ETIMEOUT. I'll ask the participants to use make test-only for now (even then this still shows up but it does not stop the build)

  10. richardlau commented on Nov 2, 2019

    @richardlau
    richardlau
    on Nov 2, 2019
    Member

    PR: #30214

  11. richardlau
    added a commit that references this issue on Nov 6, 2019

    tools: make doctool work if no internet available

    3b124e0
  12. richardlau
    closed this as completedin 3b124e0on Nov 6, 2019

  13. joyeecheung commented on Nov 10, 2019

    @joyeecheung
    joyeecheung
    on Nov 10, 2019
    MemberAuthor

    #30214 still does not fix the issue: versions() is run in multiple processes when building the docs and it's still excruciatingly slow to wait for the fallback (this already took minutes for me and it is still running).

    Screen Shot 2019-11-10 at 4 01 47 PM

  14. 1 remaining item

  15. MylesBorins
    added a commit that references this issue on Nov 17, 2019

    tools: make doctool work if no internet available

    92fa4e0
  16. targos
    added a commit that references this issue on Dec 1, 2019

    tools: make doctool work if no internet available

    ebaa738
  17. MylesBorins
    added a commit that references this issue on Dec 17, 2019

    tools: make doctool work if no internet available

    5e8b2a8
  18. joyeecheung
    closed this as completedin 914d800on Feb 25, 2020
  19. codebytere
    added a commit that references this issue on Feb 27, 2020

    tools: add NODE_TEST_NO_INTERNET to the doc builder

    f293dcf
  20. codebytere
    added 2 commits that reference this issue on Mar 15, 2020

    tools: add NODE_TEST_NO_INTERNET to the doc builder

    7840f46

    tools: add NODE_TEST_NO_INTERNET to the doc builder

    e635b53
  21. codebytere
    added a commit that references this issue on Mar 30, 2020

    tools: add NODE_TEST_NO_INTERNET to the doc builder

    1060a2b
  22. BethGriggs
    added 2 commits that reference this issue on Apr 6, 2020

    tools: make doctool work if no internet available

    ac1ea73

    tools: add NODE_TEST_NO_INTERNET to the doc builder

    3756be8
  23. sjarmak
    added a commit that references this issue on Jul 27, 2026

    tools: add NODE_TEST_NO_INTERNET to the doc builder

    914d800
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.docIssues and PRs related to Node.js documentation.toolsIssues and PRs related to the tools directory.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions