Repository navigation
configure.py: upgrade from optparse to argparse #29813
Description
Activity
Hello! I would love to try this one. Already taking a look on what I can do.
Sounds reasonable to me. For the reader, argparse also exists in 2.7: https://docs.python.org/2.7/library/argparse.html
@vccolombo Please don't start from scratch... Start with the code in #26725
Reacted by Víctor Colombo@vccolombo Please don't start from scratch... Start with the code in #26725
Hey, I opened a PR, but I could use some help there. Thank you very much
It seems this was solved, but the code didn't be merged? Should this issue be closed?
Let's leave it open. The code did not get merged so the issue remains valid.
YES. You do not have to ask for permission. Your PR needs to have some tests too. If you see something that needs fixing then please open a PR. If multiple people open a PR to fix the same issue then it is almost always a learning opportunity.
Reacted by Darshan SenReacted by KuthorX@cclaus I was wondering whether I should start with the code from #26725 or #29814. The author of the second one probably added his changes to the code mentioned in the first PR but he also mentions that the PR fails in the PR description. Also, do I simply start off by copying the code and make it work or am I supposed to fetch the commits from the PR branch, add my commits and make a PR here?
My suggestion would be that you start a brand new PR and cherrypick things that you like from the other two. Make sure that you put
closes #26725, #29813, #29814at the top of your PR (even if they are already closed) so that reviewers can quickly find details of previous attempts. Thanks for doing this!Reacted by Darshan Sen- added a commit that references this issue
on Nov 12, 2020 - added a commit that references this issue
on Nov 22, 2020
Is your feature request related to a problem? Please describe.
Please describe the problem you are trying to solve.
Describe the solution you'd like
Please describe the desired behavior.
optparse is deprecated in favor of argparse so configure.py should be upgraded to use the newer module. This could be cherrypicked from #26725 without taking the unrelated changes in that PR.
Describe alternatives you've considered
Please describe alternative solutions or features you have considered.
Leaving the code the way it is because the current DRAFT Python 3.9 docs still show support for the deprecated module.