flaky test-http2-reset-flood

[sam-github]

• Version: master
• Platform: freebsd
• Subsystem: http2

Stacktrace
<--- Last few GCs --->

[26169:0x80448acc0]    25362 ms: Scavenge 989.7 (993.9) -> 988.7 (998.4) MB, 5.8 / 0.0 ms  (average mu = 0.162, current mu = 0.042) allocation failure
[26169:0x80448acc0]    25385 ms: Scavenge 992.9 (999.2) -> 990.7 (1000.2) MB, 7.9 / 0.0 ms  (average mu = 0.162, current mu = 0.042) allocation failure
[26169:0x80448acc0]    25410 ms: Scavenge 994.1 (1000.2) -> 992.2 (1001.7) MB, 11.1 / 0.0 ms  (average mu = 0.162, current mu = 0.042) allocation failure


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x1281d39]
Security context: 0x2031aba008a1 <JSObject>
    1: valueOf [0x2031aba02591](this=0x16fe6ced18a9 <JSArray[1]>)
    2: writeRequests(aka writeRequests) [0x29a6852d0881] [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-http2-reset-flood.js:~63] [pc=0x3b2f916da4bd](this=0x3d037bd404a9 <undefined>)
    3: processTicksAndRejections [0x130a019c4e21] [internal/process...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x9a7e30 node::Abort(void) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 2: 0x9a7fa2 node::OnFatalError(char const*, char const) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 3: 0xad76a7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 4: 0xc4edd5 v8::internal::Heap::FatalProcessOutOfMemory(char const*) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 5: 0xc50613 v8::internal::Heap::RecomputeLimits(v8::internal::GarbageCollector) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 6: 0xc4d16c v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 7: 0xc4b01e v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 8: 0xc4a00e v8::internal::Heap::HandleGCRequest(void) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
 9: 0xc11275 v8::internal::StackGuard::HandleInterrupts(void) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]
10: 0xf52f28 v8::internal::Runtime_StackGuard(int, unsigned long*, v8::internal::Isolate*) [/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node]

• https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/28633/testReport/junit/(root)/test/parallel_test_http2_reset_flood/

From #29727, which seems wholly unrelated, since it changes the link flags on linux, and this is a freebsd failure.

@nodejs/platform-freebsd

[MylesBorins]

We are seeing this as flaky on 12.x on a bunch of other linux distros as well

https://ci.nodejs.org/job/node-test-commit/37126/

Not sure what we should do about this

[MylesBorins]

@addaleax also seeing this fail on windows now too (all on 12.x).

Do you think this is a real failure? Should we mark this flaky across all release lines? Expand scope of this issue?

[MylesBorins]

Here is an example of it failing across almost every platform

https://ci.nodejs.org/job/node-test-commit/37128/

[addaleax]

@MylesBorins The v12.x failures seem very different from the failure on master. I could reproduce the v12.x failures locally on Linux. This patch fixes it for me and shouldn’t affect the test’s functionaliy:

diff --git a/test/parallel/test-http2-reset-flood.js b/test/parallel/test-http2-reset-flood.js
index 7ee534cf4faa..d721384ab374 100644
--- a/test/parallel/test-http2-reset-flood.js
+++ b/test/parallel/test-http2-reset-flood.js
@@ -69,9 +69,10 @@ const worker = new Worker(__filename).on('message', common.mustCall((port) => {
       h2header.writeIntBE(streamId, 5, 4);  // Stream ID
       streamId += 2;
       // 0x88 = :status: 200
-      conn.write(Buffer.concat([h2header, Buffer.from([0x88])]));
+      if (conn.writable)
+        conn.write(Buffer.concat([h2header, Buffer.from([0x88])]));
     }
-    if (!gotError)
+    if (conn.writable && !gotError)
       setImmediate(writeRequests);
   }
 

I’m not sure why it’s not needed on master but it’s probably because @ronag put a lot of work into streams finally making sense.

Either way, feel free to take that patch and open a PR with it 🙂