Skip to content

pty_helper.py doesn't work with python3 #29166

Closed
@sam-github

Description

@sam-github

In process of
#25789 this is seen:

make test PYTHON=python3

Path: pseudo-tty/test-tty-color-support
Traceback (most recent call last):
  File "/home/sam/w/core/lts/test/pseudo-tty/pty_helper.py", line 97, in <module>
    if pipe(parent_fd, STDOUT):
  File "/home/sam/w/core/lts/test/pseudo-tty/pty_helper.py", line 33, in pipe
    n = os.write(dfd, data)
TypeError: a bytes-like object is required, not 'filter'

Affects most(all?) pseudo-tty tests.

/cc @cclauss @bnoordhuis @nodejs/python

Metadata

Metadata

Assignees

No one assigned

    Labels

    pythonPRs and issues that require attention from people who are familiar with Python.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions