Skip to content

http: OutgoingMessage instanceof Writable #28971

Closed
Closed
http: OutgoingMessage instanceof Writable#28971

Description

@ronag
ronag
opened on Aug 5, 2019

Would it be an idea to make OutgoingMessage inherit the Writable prototype but where we override all methods. Just in order to make msg instanceof Writable work?

Activity

  1. ronag commented on Aug 5, 2019

    @ronag
    ronag
    on Aug 5, 2019
    MemberAuthor

    ping @mcollina

  2. mcollina commented on Aug 5, 2019

    @mcollina
    mcollina
    on Aug 5, 2019
    SponsorMember

    I tried this in the past, but I got a significant performance drop. I'm happy to review a PR, if it has no performance loss.

  3. rexagod
    added a commit that references this issue on Jun 14, 2020

    http: make http.OutgoingMessage inherit Stream.Writable

    85247a0

  4. mcollina commented on Jun 14, 2020

    @mcollina
    mcollina
    on Jun 14, 2020
    SponsorMember

    I would recommend we close this issue as it’s likely not doable without a significant slowdown in the current state of affairs.

  5. ronag
    closed this as completedon Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions