tls.DEFAULT_MIN_VERSION according to docs is v11 feature, but its present in v10.16.0 and is incorrect

[nitinsurana]

• Version: 10.16.0
• Platform: Ubuntu 14.04

According to the docs tls.DEFAULT_MIN_VERSION is available starting v11 and default value is TLSv1.2

Issue :

1. Ubuntu 14.04 with Nodejs v10.16.0 has tls.DEFAULT_MIN_VERSION defined
2. It is returning incorrect value viz TLSv1 instead of TLSv1.2

[nitinsurana]

Possibly, this commit needs to be merged with 10x

[Trott]

Possibly, this commit needs to be merged with 10x

No, that's just a changelog entry.

[Trott]

Seems like #26821 needs to be added to v10.x-staging (so it can go out in the next release).

[sam-github]

It is returning incorrect value viz TLSv1 instead of TLSv1.2

Value is correct, you are reading 12.x docs, the 11.x docs are slightly more relevant to 10.x: https://nodejs.org/docs/latest-v11.x/api/tls.html#tls_tls_default_min_version

[ckarande]

I would like to assist on this issue and starting to exploring it further.
cc: @mcollina

[mcollina]

@ckarande do you need any direction/help? Check out https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md.

[ckarande]

@mcollina Thanks for the link. I am all set to go ahead with it.

[ckarande]

@sam-github @nitinsurana @Trott I am comparing the changes in #26821 with what is applicable to v10.x. Can you please confirm these findings:

1. In protocol versions, remove references of TLSv1.3,as it was not supported in v10
2. Remove references to CLI options such as --tls-min-v1.0, --tls-min-v1.2, --tls-min-v1.3, --tls-max-v1.2 --tls-max-v1.3 as they do not seem to be supported in v10.x.