Skip to content

REPL complete function swallows errors #28546

@BridgeAR

Description

@BridgeAR

@estrada9166 recently brought up that test/parallel/test-repl-save-load.js is not working as it should. It should fail as is it but the errors are swallowed due to calling complete.

It seems like the domain does not propagate the error properly and it's silently swallowed. Adding an error listener to the active domain in the complete function that throws the error fixes the problem but it causes some side effects in other cases. We should only add the listener to the domains that do not handle the error properly at the moment.

Ping @Trott since you fixed some of these cases before.

Metadata

Metadata

Assignees

No one assigned

    Labels

    confirmed-bugIssues with confirmed bugs.replIssues and PRs related to the REPL subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions