-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
Closed
Labels
pythonPRs and issues that require attention from people who are familiar with Python.PRs and issues that require attention from people who are familiar with Python.testIssues and PRs related to the tests.Issues and PRs related to the tests.
Description
Lest I forget: the master fd created here:
Line 723 in 20d099a
(out_master, fd_out) = pty.openpty() |
Is leaked to the spawned child here:
Lines 761 to 772 in 20d099a
(process, exit_code, timed_out, output) = RunProcess( | |
context, | |
timeout, | |
args = args, | |
stdin = fd_in, | |
stdout = fd_out, | |
stderr = fd_err, | |
env = env_copy, | |
faketty = faketty, | |
pty_out = pty_out, | |
preexec_fn = preexec_fn | |
) |
Fix: the preexec_fn
should os.close(pty_out)
.
Metadata
Metadata
Assignees
Labels
pythonPRs and issues that require attention from people who are familiar with Python.PRs and issues that require attention from people who are familiar with Python.testIssues and PRs related to the tests.Issues and PRs related to the tests.