Skip to content

build/lint on Windows is slightly broken #28086

Closed
@jasnell

Description

Just leaving this here for now because I don't have time to chase it down... vcbuild lint on Windows is linting the cctest/gtest tool but it shouldn't be. /cc @nodejs/platform-windows

λ vcbuild lint
running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\js-native-api\*.cc test\js-native-api\*.cc test\js-native-api\*.h test\node-api\*.cc test\node-api\*.cc test\node-api\*.h test\cctest\*.cc test\cctest\*.h tools\icu\*.cc tools\icu\*.h'
test\cctest\gtest\gtest-all.cc:436:  "stdlib.h" already included at test\cctest\gtest\gtest-all.cc:315  [build/include] [4]
test\cctest\gtest\gtest-all.cc:439:  "algorithm" already included at test\cctest\gtest\gtest-all.cc:320  [build/include] [4]
test\cctest\gtest\gtest-all.cc:442:  "vector" already included at test\cctest\gtest\gtest-all.cc:327  [build/include] [4]
test\cctest\gtest\gtest-all.cc:781:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:781:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1965:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1966:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:1984:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4829:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4873:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
test\cctest\gtest\gtest-all.cc:4877:  Use left leaning pointer instead of right leaning  [readability/pointer_notation] [2]
...

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions