Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the runtime stack size. #27488

Closed
fenginsc opened this issue Apr 30, 2019 · 8 comments
Closed

modify the runtime stack size. #27488

fenginsc opened this issue Apr 30, 2019 · 8 comments
Labels
feature request Issues that request new features to be added to Node.js. stale

Comments

@fenginsc
Copy link

Is your feature request related to a problem? Please describe.
I hope I can modify the runtime stack size.

Describe the solution you'd like
no,sorry.

Describe alternatives you've considered
no,sorry.

because --stack-size does not work now,I hope I can modify the runtime stack size.

@bnoordhuis bnoordhuis added the feature request Issues that request new features to be added to Node.js. label Apr 30, 2019
@bnoordhuis
Copy link
Member

I think this is in reaction to #27472 and ultimately #17416? I think our position is still the same: pull request welcome :-)

Can you explain your use case though? W.r.t. your test case from #27472: no finite amount of stack space is going to solve infinite recursion.

@fenginsc
Copy link
Author

fenginsc commented May 5, 2019

thanks,you are right.
[no finite amount of stack space is going to solve infinite recursion]
but Java provides parameters to modify stack size(-Xss),I think it's also necessary for nodejs to provide a parameter to modify the stack size to deal with stack overflows in some cases.

@fenginsc
Copy link
Author

fenginsc commented May 5, 2019

The default stack size 984 of Node.js is incorrect. It will cause runtime crash on Windows. The correct value should be around 900.

@bnoordhuis
Copy link
Member

With what Node.js and Windows version is that and do you have a test case that demonstrates it?

We'd be receiving lots of bug reports if it were generally true that the current default causes crashes but maybe there's a specific set of conditions that pushes it over the limit.

@DavenportEmma
Copy link
Contributor

Would someone be able to give me a few pointers on where to start for this? I'm new to contributing and looking for an issue to work on

@github-actions
Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

1 similar comment
@github-actions
Copy link
Contributor

There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.

For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions
Copy link
Contributor

There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.

For more information on how the project manages feature requests, please consult the feature request management document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issues that request new features to be added to Node.js. stale
Projects
None yet
Development

No branches or pull requests

3 participants