Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: support sha512 in the ICU current_ver.dep #27369

Closed
srl295 opened this issue Apr 23, 2019 · 1 comment
Closed

tools: support sha512 in the ICU current_ver.dep #27369

srl295 opened this issue Apr 23, 2019 · 1 comment
Assignees
@srl295
Labels
i18n-api Issues and PRs related to the i18n implementation.

Comments

@srl295
Copy link
Member

srl295 commented Apr 23, 2019

@srl295
Copy link
Member Author

srl295 commented Apr 23, 2019

Something like this:

[
  {
    "url": "https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-src.tgz",
    "sha512": "5ecb4c230ba45918747a1cf9aef86f555aa07d5b29b1d07ab674e8013f46dfb907a0e9d6945db41155f9dc3012fd94e1152ffc19f61a68b6dfcbabdcb8ae9d78"
  }
]

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Apr 23, 2019
@srl295 srl295 self-assigned this Apr 23, 2019
@srl295 srl295 mentioned this issue Apr 23, 2019
Closed
3 tasks
@srl295 srl295 mentioned this issue Apr 23, 2019
Closed
2 tasks
@srl295 srl295 closed this as completed Apr 26, 2019
srl295 added a commit that referenced this issue Apr 26, 2019
@srl295
build: allow icu download to use other hashes besides md5
d04b376 
- ICU uses sha512 instead of md5 in some recent releases
- Use hashlib.algorithms_guaranteed to choose the following algorithms:
    sha1 sha224 sha384 sha256 sha512 md5
- No preference as to the priority of the algorithms
- This commit does not change the hash used for ICU.

Fixes: #27369
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-by: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-by: Richard Lau <riclau@uk.ibm.com>
PR-URL: #27370
targos pushed a commit that referenced this issue Apr 27, 2019
@srl295 @targos
build: allow icu download to use other hashes besides md5
e7026f1 
- ICU uses sha512 instead of md5 in some recent releases
- Use hashlib.algorithms_guaranteed to choose the following algorithms:
    sha1 sha224 sha384 sha256 sha512 md5
- No preference as to the priority of the algorithms
- This commit does not change the hash used for ICU.

Fixes: #27369
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-by: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-by: Richard Lau <riclau@uk.ibm.com>
PR-URL: #27370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: allow icu download to use sha512 over md5 srl295/node
1 participant
@srl295