Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in esm loader from 10.15.2 to 10.15.3 #26595

Closed
catdad opened this issue Mar 11, 2019 · 2 comments
Closed

regression in esm loader from 10.15.2 to 10.15.3 #26595

catdad opened this issue Mar 11, 2019 · 2 comments

Comments

@catdad
Copy link

catdad commented Mar 11, 2019

  • Version: 10.15.3
  • Platform: all (I used Ubuntu)
  • Subsystem:

The ESM loader broke between versions 10.15.2 and 10.15.3

Repro steps:

Using request-promise-native as a test case:

npm install request-promise-native@1.0.5

Then create the following test.mjs file:

import lib from 'request-promise-native';

Using node --experimental-modules test.mjs the code executes fine in 10.15.2 but errors in 10.15.3 with the following error:

TypeError: Cannot read property 'onReady' of undefined
    at Module.load (internal/modules/cjs/loader.js:611:22)
    at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
    at Function.Module._load (internal/modules/cjs/loader.js:531:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (/mnt/c/Workspace/Gitlab/preditor/node_modules/psl/index.js:14:19)
    at Module._compile (internal/modules/cjs/loader.js:701:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:712:10)
    at Module.load (internal/modules/cjs/loader.js:600:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:539:12)

image

image

@mririgoyen
Copy link

Looks like this change may have caused the regression: #24560

@devsnek
Copy link
Member

devsnek commented Mar 11, 2019

Duplicate of #25482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants