createConnection option not work for https module

Version: v10.13.0
Platform: Linux 4.15.0-39-generic x86_64

I am trying to use the createConnection option in the https module to set the client local port (localPort=34567 in the example below), but this only works when port = 80, not when port = 443. Following is the code I used to test. Does it mean that https module cannot set a custom socket for https in this way? Thanks.

const https = require('https');
const url = require('url');

var req = https.get({
    host: 'google.com',
    pathname: '/',
    port: 443,   // works when equal to 80, but not 443
    family: 4,
    localPort: 34567,
    createConnection: require('net').createConnection
}, function(res) {
    console.log('localPort:', req.socket.localPort, "remotePort:", req.socket.remotePort);
});

req.on('error', console.error);

@nodejs/http Seems like a legit bug in the https module?

@leeight

@leeight , thanks.
Adding localPort does enforce the local port, but it cannot be used together with the createConnection option. Why createConnection only works for http, not https?

but this only works when port = 80, not when port = 443
Why createConnection only works for http, not https?

I thinks it's because net.createConnection() and port 80 use HTTP, not HTTPS. The HTTPS agent's createConnection() is built around tls.connect().

https: add missing localPort while create socket

@cjihrig

@cjihrig creatConnection is useful for opening a custom socket. Can this feature be added for HTTPS? Or is there a way to customize socket for HTTPS? Thanks!

@eecs441staff does createConnection: require('tls').connect not work for you?

@cjihrig

@cjihrig It worked! Thanks.

Sounds to me like this can be closed, but comment and/or re-open if I've misunderstood.

https: add missing localPort while create socket

Navigation Menu

Repository navigation

createConnection option not work for https module #24543

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

createConnection option not work for https module #24543

Description

Activity

Trott commented on Nov 21, 2018

yibopi commented on Nov 21, 2018

cjihrig commented on Nov 22, 2018

eecsreactive commented on Nov 27, 2018

cjihrig commented on Nov 27, 2018

eecsreactive commented on Nov 27, 2018

Trott commented on Dec 1, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions