Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Crypto Cipher and Decipher examples use deprecated createCipher and createDecipher #24046

Closed
mayankasthana opened this issue Nov 2, 2018 · 2 comments
Closed

docs: Crypto Cipher and Decipher examples use deprecated createCipher and createDecipher #24046

mayankasthana opened this issue Nov 2, 2018 · 2 comments

Comments

@mayankasthana
Copy link
Contributor

The examples at
https://github.com/nodejs/node/blob/v11.1.0/doc/api/crypto.md#class-cipher

const cipher = crypto.createCipher('aes192', 'a password');

and

https://github.com/nodejs/node/blob/v11.1.0/doc/api/crypto.md#class-decipher

const decipher = crypto.createDecipher('aes192', 'a password');

use deprecated methods crypto.createCipher() and crypto.createDecipher().

The examples should be updated to use crypto.createCipheriv() and crypto.createDecipheriv() instead.
@mayankasthana mayankasthana changed the title Crypto Cipher and Decipher examples use deprecated createCipher and createDecipher docs: Crypto Cipher and Decipher examples use deprecated createCipher and createDecipher Nov 2, 2018
@aduh95
Copy link
Contributor

aduh95 commented Nov 4, 2018

@mayankasthana Do you want to submit a PR to fix that?

@mayankasthana
Copy link
Contributor Author

Sure!

@mayankasthana mayankasthana mentioned this issue Nov 5, 2018
Closed
3 tasks
mayankasthana added a commit to mayankasthana/node that referenced this issue Nov 10, 2018
@mayankasthana
doc: update crypto examples to not use deprecated api
cf8563e 
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.

Fixes: nodejs#24046
@Trott Trott closed this as completed in 9730903 Nov 19, 2018
targos pushed a commit that referenced this issue Nov 19, 2018
@mayankasthana @targos
doc: update crypto examples to not use deprecated api
0d8725f 
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.

Fixes: #24046

PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
rvagg pushed a commit that referenced this issue Nov 28, 2018
@mayankasthana @rvagg
doc: update crypto examples to not use deprecated api
ed78339 
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.

Fixes: #24046

PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
codebytere pushed a commit that referenced this issue Jan 13, 2019
@mayankasthana @codebytere
doc: update crypto examples to not use deprecated api
8475fb1 
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.

Fixes: #24046

PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
refack pushed a commit to refack/node that referenced this issue Jan 14, 2019
@mayankasthana @refack
doc: update crypto examples to not use deprecated api
ec59477 
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.

Fixes: nodejs#24046

PR-URL: nodejs#24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
codebytere pushed a commit that referenced this issue Jan 29, 2019
@mayankasthana @codebytere
doc: update crypto examples to not use deprecated api
7fd4ef7 
Updated Cipher and Decipher examples to not use deprecated
`crypto.createCipher` and `crypto.createDecipher` in examples and
instead use `createCipheriv` and `createDecipheriv`.

Fixes: #24046

PR-URL: #24107
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mayankasthana @aduh95