Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nominating @shisama as a collaborator #23850

Closed
addaleax opened this issue Oct 24, 2018 · 7 comments
Closed

Nominating @shisama as a collaborator #23850

addaleax opened this issue Oct 24, 2018 · 7 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@addaleax
Copy link
Member

I'd like to nominate @shisama as a Collaborator. With 30 commits and consistent engagement in Node.js core, this should probably have happened a while ago :)

Commits: https://github.com/nodejs/node/commits?author=shisama
Comments: https://github.com/nodejs/node/search?q=commenter%3Ashisama&type=Issues
@addaleax addaleax added the meta Issues and PRs related to the general management of the project. label Oct 24, 2018
@gireeshpunathil
Copy link
Member

+1

4 similar comments
@mhdawson
Copy link
Member

+1

@cjihrig
Copy link
Contributor

cjihrig commented Oct 24, 2018

+1

@BridgeAR
Copy link
Member

+1

@hiroppy
Copy link
Member

hiroppy commented Oct 25, 2018

+1

@addaleax addaleax mentioned this issue Oct 29, 2018
Closed
@fhinkel
Copy link
Member

fhinkel commented Oct 30, 2018

+1

@joyeecheung joyeecheung added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Oct 31, 2018
@joyeecheung
Copy link
Member

This has been open for a week so according to the GOVERNANCE.md the nomination has now been considered accepted. Marking it as tsc-agenda so that it gets announced at the TSC meeting.

@mhdawson mhdawson mentioned this issue Nov 5, 2018
Closed
@Trott Trott removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Nov 5, 2018
@shisama shisama mentioned this issue Nov 6, 2018
Closed
2 tasks
@shisama shisama closed this as completed in a49b672 Nov 6, 2018
targos pushed a commit that referenced this issue Nov 6, 2018
@targos
doc: add shisama to collaborators
f9f185a 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this issue Nov 15, 2018
@kiyomizumia
doc: add shisama to collaborators
9977dd4 
PR-URL: nodejs#24136
Fixes: nodejs#23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
codebytere pushed a commit that referenced this issue Nov 29, 2018
@codebytere
doc: add shisama to collaborators
5f14b4e 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 29, 2018
@MylesBorins
doc: add shisama to collaborators
f80423b 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this issue Dec 3, 2018
@MylesBorins
doc: add shisama to collaborators
ec43b32 
PR-URL: #24136
Fixes: #23850
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add shisama to collaborators shisama/node
9 participants
@fhinkel @Trott @addaleax @cjihrig @hiroppy @joyeecheung @gireeshpunathil @BridgeAR @mhdawson