-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: process.stdout.fd is mentioned but undocumented #22873
Comments
I think those only exist when stdio is a net.Socket (and probably comes from net.Socket), not sure that the FS thing has the same property. We might want to specify what the stdio "handles" can inherit from (what classes they can be). |
@nodejs/documentation @nodejs/process |
|
So mention of its use should be removed from the |
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: nodejs#22873
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: nodejs#22873 PR-URL: nodejs#24741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Fixed in 9159fb7 |
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: #22873 PR-URL: #24741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: nodejs#22873 PR-URL: nodejs#24741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: #22873 PR-URL: #24741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: #22873 PR-URL: #24741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
The examples show `process.stdout.fd` as a means to use synchronous writes in async_hooks context. However this is an undocumented field, so showcase a file write example instead. Fixes: #22873 PR-URL: #24741 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
process.stdout.fd
is mentioned in these 2 sections:https://nodejs.org/api/async_hooks.html#async_hooks_printing_in_asynchooks_callbacks
https://nodejs.org/api/async_hooks.html#async_hooks_asynchronous_context_example
But it is not documented in
process.stdout
or in a section of any mentioned prototype (net.Socket
, Duplex or Writable stream).Should it be documented with
process.stdin.fd
andprocess.stderr.fd
?The text was updated successfully, but these errors were encountered: